fix locator resource pool #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the documentation states, topological sorting of modules within 'raw' sections was not enabled by default. Sorting is based on dependencies only, so enabling it by default should only solve issues in case dependencies are declared but sort was not enabled. If no dependencies are defined, the order will not change. This could only break use cases where dependencies have been wrongly declared and a user relies on the current unsorted order.
…attern
Ensures that the build task "replaceVersion" replaces
the pattern ${project.version} equally to ${version}.
JIRA: CPOUI5FOUNDATION-423
Fixes that libraries using a "library.js" file but no ".library" file can also build theming files.
Combines debug-file creation, source-map generation and minification. Replaces existing tasks/processors 'uglify' and 'createDebugFiles'. Also introduce new global tags `IsDebugVariant` and `HasDebugVariant`. BREAKING CHANGE: The following tasks have been removed: - createDebugFiles - uglify The following processors have been removed: - debugFileCreator - resourceCopier - uglifier As a replacement, the new 'minify' task and 'minifier' processor can be used. Note: The minify task is executed earlier, before the bundling process takes place. Existing 'beforeTask' and 'afterTask' configuration of custom tasks might need to be adapted to cater for this change.
bundleOptions are often omitted. So document them as optional and always default 'optimize' to true, even if bundleOptions are specified.
Source maps are currently only required during the build process (e.g. for creating source maps of bundles) but not as build output. Therefore they will be omitted from the build result.
…result Resources that are tagged to be omitted from the build result should not be listed in the resources.json as it should represent a listing of files that are part of the build output. Resources of dependencies should also not be used for dependency lookups if they are omitted from the results as they also won't be listed in the resources.json of that dependency.
BREAKING CHANGE: Support for older Node.js and npm releases has been dropped. Only Node.js v16.13.2 and npm v8 or higher are supported.
By upgrading espree to the latest version, ES2021 language features are now supported.
…#689) Sort modules in preload sections alphabetically. This caused different bundle contents based on the order of modules that the resolver provides, which is not deterministic. Remove terser from size estimation as modules are now already optimized if the 'optimize' bundle option is enabled. This caused incorrect estimations about the bundle size which resulted into size differences of the individual parts.
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
JIRA: CPOUI5FOUNDATION-424
Resolves SAP/ui5-tooling#472 Supersedes #282 Based on SAP/ui5-tooling#583 JIRA: CPOUI5FOUNDATION-434 Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
The FragmentDefinition node should be skipped, but it may still contain a core:require definition. This is in line with the current runtime which also reads the require and loads the module.
Folders have been added by mistake and are not used by any test.
* Always sort by semver instead of date to fix changelog generation when different branches are tagged at intersecting times * For release notes on the current next branch, ignore any tags <=v2 to ensure that we always compare to a v3 tag (sorting by semver doesn't seem to work here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize: true([BREAKING] moduleBundler: Always default tooptimize: true#685)