Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] AbstractAdapter: Add excludes option #140

Merged
merged 17 commits into from
May 29, 2019
Merged

Conversation

RandomByte
Copy link
Member

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 21, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 84.828% when pulling 7d610ae on static-excludes into 79a3637 on master.

@coveralls
Copy link

coveralls commented May 21, 2019

Coverage Status

Coverage increased (+1.4%) to 85.792% when pulling cb1905d on static-excludes into cef49a7 on master.

- globby: 'nodir' option renamed to 'onlyFiles'
- globby: Now transforms empty GLOB strings into globstar (matching
everything instead of nothing)
    - mitigated by not globbing with empty strings anymore
- globby/micromatch: Including excluded paths is now possible
    - before this was inconsistent
- FileSystem._runGlob now throws errors for glob errors (instead of
catching and logging them)
This caused loops in cyclic npm dependencies.
The 'follow' option of node-glob also defaults to false.
The useNamespace flag was not sufficient in cases where the namespace
should only be added for projects that do not already represent it in
their directory structure.

With SAP/ui5-builder#255 libraries will have a
namespace property even though their directory structure already
represents the namespace.
RandomByte added a commit to SAP/ui5-server that referenced this pull request May 27, 2019
RandomByte added a commit to SAP/ui5-server that referenced this pull request May 27, 2019
…or GLOB errors

See SAP/ui5-fs#140

The tmp directory might not be present during the execution of this
test. However, its usage didn't really add any value to the test
anyways.
RandomByte added a commit to SAP/ui5-server that referenced this pull request May 28, 2019
…ow throws for GLOB errors

See SAP/ui5-fs#140

The tmp directory might not be present during the execution of this
test. However, its usage didn't really add any value to the test
anyways.
RandomByte added a commit to SAP/ui5-server that referenced this pull request May 28, 2019
…ow throws for GLOB errors

See SAP/ui5-fs#140

The tmp directory might not be present during the execution of this
test. However, its usage didn't really add any value to the test
anyways.
@RandomByte RandomByte requested a review from matz3 May 28, 2019 16:36
lib/adapters/AbstractAdapter.js Outdated Show resolved Hide resolved
lib/adapters/FileSystem.js Outdated Show resolved Hide resolved
lib/adapters/FileSystem.js Outdated Show resolved Hide resolved
lib/adapters/Memory.js Outdated Show resolved Hide resolved
lib/adapters/AbstractAdapter.js Outdated Show resolved Hide resolved
test/lib/glob.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
- Rename isExcludedPath to isPathExcluded
- Also resolve with null instead of undefined if a resource has been
  excluded
- Rename GLOB to glob as already decided earlier
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RandomByte RandomByte merged commit daef31f into master May 29, 2019
@RandomByte RandomByte deleted the static-excludes branch May 29, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants