feat(ui5-avatar): introduce new component #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested changes
Jan 14, 2020
There was a problem hiding this comment.
I tested it and looks great, I have two suggestion to the API:
- make the image a slot so that the user may supply "alt" as well.
- For the icon I think it makes sense to have a property, but to be consistent it would be "icon" and not "iconSrc".
So you have:
<ui5-avatar><img src="..." alt="..."></ui5-avatar>
or
<ui5-avatar icon="user"></ui5-avatar>
MapTo0
previously approved these changes
Jan 14, 2020
vladitasev
previously approved these changes
Jan 14, 2020
vladitasev
approved these changes
Jan 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.