Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-table): introduce popinChange event #1166

Merged
merged 4 commits into from
Feb 3, 2020

Conversation

ivoplashkov
Copy link
Member

New event "popinChange" has been introduced.

FIXES: #1106

@@ -106,6 +106,7 @@ const metadata = {
},
},
events: /** @lends sap.ui.webcomponents.main.Table.prototype */ {
popinChange: {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docs for the event:
Event explanation
@ event
@ since 1.0.0-rc.6
@ public

(no spaces after the @)

@@ -242,6 +243,7 @@ class Table extends UI5Element {
// invalidate only if hidden columns count has changed
if (this._hiddenColumns.length !== hiddenColumns.length) {
this._hiddenColumns = hiddenColumns;
this.fireEvent("popinChange");
Copy link
Member

@ilhan007 ilhan007 Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect also to get the array of popped in columns if I listen for this event

@fifoosid
Copy link
Contributor

You can add a test as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'popin' event for Table
4 participants