feat(ui5-table): introduce popinChange event #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
suggested changes
Jan 30, 2020
packages/main/src/Table.js
Outdated
| @@ -106,6 +106,7 @@ const metadata = { | |||
| }, | |||
| }, | |||
| events: /** @lends sap.ui.webcomponents.main.Table.prototype */ { | |||
| popinChange: {}, | |||
There was a problem hiding this comment.
Please add docs for the event:
Event explanation
@ event
@ since 1.0.0-rc.6
@ public
(no spaces after the @)
ilhan007
previously requested changes
Jan 30, 2020
packages/main/src/Table.js
Outdated
| @@ -242,6 +243,7 @@ class Table extends UI5Element { | |||
| // invalidate only if hidden columns count has changed | |||
| if (this._hiddenColumns.length !== hiddenColumns.length) { | |||
| this._hiddenColumns = hiddenColumns; | |||
| this.fireEvent("popinChange"); | |||
There was a problem hiding this comment.
I expect also to get the array of popped in columns if I listen for this event
|
You can add a test as well |
vladitasev
approved these changes
Feb 3, 2020
fifoosid
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New event "popinChange" has been introduced.
FIXES: #1106