fix: apply size "compact" for StaticArea items #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
vladitasev
previously requested changes
Feb 11, 2020
packages/base/src/UI5Element.js
Outdated
| } | ||
|
|
||
| updateStaticAreaItemContentDensity() { | ||
| const staticAreaItem = this.getStaticAreaItemDomRef().host; |
There was a problem hiding this comment.
IMO it's a bit safer to check for ".host" only if there is staticAreaItemDomRef()
packages/base/src/UI5Element.js
Outdated
| const staticAreaItem = this.getStaticAreaItemDomRef().host; | ||
|
|
||
| if (staticAreaItem) { | ||
| staticAreaItem.classList.toggle("sapUiSizeCompact", this.isCompact); |
There was a problem hiding this comment.
Note: The second parameter is not supported in Internet Explorer or Opera 12 and earlier.
https://www.w3schools.com/jsref/prop_element_classlist.asp
Just verified it, does not work on IE.
Also, this could would better become a function in StaticAreaItem.js and you just call this function from updateStaticAreaItemContentDensity
vladitasev
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.