Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-datepicker): enable day selection in IE #162

Merged
merged 2 commits into from
Mar 12, 2019
Merged

fix(ui5-datepicker): enable day selection in IE #162

merged 2 commits into from
Mar 12, 2019

Conversation

ilhan007
Copy link
Member

No description provided.

@ilhan007
Copy link
Member Author

Issue
In IE the target of the click is different, compared to all other browsers, preventing the day selection

Temporary solution
add additional check (considering which DOM node is the target of the click in IE).

The long term solution would be to make all days ( in the day picker) internal web components,
handling the clicks on the days.

@ilhan007 ilhan007 merged commit 18a3c43 into master Mar 12, 2019
@ilhan007 ilhan007 deleted the fix-dp branch March 12, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pskelin pskelin pskelin approved these changes

@a-z-ivanov a-z-ivanov Awaiting requested review from a-z-ivanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilhan007 @pskelin