Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-tab-container): implement overflow-button slot #2192

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Sep 8, 2020

Fixes #2184

@fifoosid fifoosid changed the title feat(ui5-tab-container): implement overflo-button slot feat(ui5-tab-container): implement overflow-button slot Sep 8, 2020
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom button is always there, no matter if an overflow menu is needed or not:
image

The normal button hides/appears properly

packages/main/src/TabContainer.js Outdated Show resolved Hide resolved
packages/main/src/TabContainer.js Outdated Show resolved Hide resolved
packages/main/src/TabContainer.js Show resolved Hide resolved
@ilhan007 ilhan007 modified the milestone: 0.23.2 Sep 14, 2020
@fifoosid fifoosid merged commit e91c200 into master Sep 14, 2020
@fifoosid fifoosid deleted the tabcontainer-menu-button branch September 14, 2020 07:27
Todor-ads pushed a commit to Todor-ads/ui5-webcomponents that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request][A11Y][TabContainer] Need a parameter to custom the aria-label text for overflow menu button
3 participants