Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-input): prevent js error when element is removed from DOM #2405

Merged
merged 1 commit into from
Oct 28, 2020
Merged

fix(ui5-input): prevent js error when element is removed from DOM #2405

merged 1 commit into from
Oct 28, 2020

Conversation

fifoosid
Copy link
Contributor

Fixes #2389

@fifoosid fifoosid merged commit 0e507eb into master Oct 28, 2020
@fifoosid fifoosid deleted the input-popover branch October 28, 2020 08:01
ilhan007 pushed a commit that referenced this pull request Nov 11, 2020
@fifoosid @ilhan007
fix(ui5-input): prevent js error when element is removed from DOM (#2405
8e1d168 
)
ilhan007 pushed a commit that referenced this pull request Nov 19, 2020
@fifoosid @ilhan007
fix(ui5-input): prevent js error when element is removed from DOM (#2405
f0aac3c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-input: conditional rendering of ui5-popover with ui5-input as content throws shadowRoot error
2 participants
@fifoosid @vladitasev