Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-list): remove focus trap for empty list #2411

Merged
merged 2 commits into from
Nov 30, 2020
Merged

fix(ui5-list): remove focus trap for empty list #2411

merged 2 commits into from
Nov 30, 2020

Conversation

fifoosid
Copy link
Contributor

This PR fixes a problem in ui5-list.
Prior to this change, two divs for focus trapping were always rendered.

After this change they are only rendered if there is at least one item in the list.(Not rendered for empty lists)

vladitasev
vladitasev previously requested changes Oct 28, 2020
View reviewed changes
packages/main/src/List.js Outdated Show resolved Hide resolved
@fifoosid fifoosid merged commit 5f8e0e2 into master Nov 30, 2020
@fifoosid fifoosid deleted the list-no-data branch November 30, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fifoosid @ilhan007 @vladitasev