feat(ui5-flexible-column-layout): add start/mid/endColumnAccessibleName properties #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, midColumnAccessibleText and endColumnAccessibleText properties
ilhan007
reviewed
Nov 19, 2020
| * @public | ||
| * @since 1.0.0-rc.11 | ||
| */ | ||
| startColumnAccessibleText: { |
There was a problem hiding this comment.
I think accessibleName is the correct term, here it is accessibleText. But, I will have to discuss it with responsible team.
ilhan007
reviewed
Nov 24, 2020
| @@ -90,7 +90,7 @@ const metadata = { | |||
| * @public | |||
| * @since 1.0.0-rc.11 | |||
| */ | |||
| startColumnAccessibleText: { | |||
| startColumnAccessibleName: { | |||
There was a problem hiding this comment.
and the properties' descriptions - "accessibility text" to "accessible name"
ilhan007
changed the title
ilhan007
changed the title
ilhan007
changed the title
ilhan007
requested changes
Nov 27, 2020
ilhan007
approved these changes
Nov 30, 2020
ilhan007
pushed a commit
that referenced
this pull request
Dec 7, 2020
fifoosid
added a commit
that referenced
this pull request
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add startColumnAccessibleText, midColumnAccessibleText and endColumnAccessibleText properties
Fixes #2464