feat(ui5-card): fires headerPress event upon header click #250
Conversation
headerPress is now fired on header click or via ENter and Space keys. Focus and active states are implemented upon those actions.
…ebcomponents into feat-card-header-press
ilhan007
changed the title
| @@ -3,6 +3,8 @@ import URI from "@ui5/webcomponents-base/src/types/URI"; | |||
| import Bootstrap from "@ui5/webcomponents-base/src/Bootstrap"; | |||
| import ShadowDOM from "@ui5/webcomponents-base/src/compatibility/ShadowDOM"; | |||
| import { isIconURI } from "@ui5/webcomponents-base/src/IconPool"; | |||
| import { isSpace, isEnter, } from "@ui5/webcomponents-base/src/events/PseudoEvents"; | |||
| import Function from "@ui5/webcomponents-base/src/types/Function"; | |||
There was a problem hiding this comment.
there is a native type function so I think we can skip this?
There was a problem hiding this comment.
There is, but the metadata validation would not pass for now. As this refactoring is started by Vladi, I will change it to native Function once it's done.
| @@ -82,6 +84,26 @@ const metadata = { | |||
| type: URI, | |||
| defaultValue: null, | |||
| }, | |||
|
|
|||
| _headerActive: { | |||
There was a problem hiding this comment.
This one is for the pressed state, but there could be a public property determining wether the header is active or not (activeHeader as you said) and then this would be renamed to _pressedHeader or similar.
packages/main/src/Card.js
Outdated
| @@ -133,6 +167,42 @@ class Card extends WebComponent { | |||
|
|
|||
| super.define(...params); | |||
| } | |||
|
|
|||
| headerPress(event) { | |||
| const click = event.type === "click"; | |||
There was a problem hiding this comment.
I am not really sure how stable is this.
There was a problem hiding this comment.
Yes, this approach is arguable, we can discuss it briefly today.
|
|
headerPress is now fired on header click or via Enter and Space keys.
Focus and active states are implemented upon those actions.
Fixes: #243