Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-slider): add more tests, add cozy styles, fix input event, fix tickmarks display #2508

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

ndeshev
Copy link
Contributor

@ndeshev ndeshev commented Nov 23, 2020

  • New tests are added to cover using 'effective' properties for
    calculation instead of normalizations of the real ones.

  • Added cozy styles and set as default while the compact css vars are now
    moved to sizes-parameters.css files.

  • Input event is now fixed and fired only after the current value is
    changed by user interaction.

  • Updating the labels based on the other properties is fixed - labels are
    now getting re-created if the one of the other component's properties is updated.

  • Tickmarks bug that sometimes the tickmarks get hidden under the parent's
    background is fixed, the tickmarks DOM no longer has a z-index set to -1.

New tests are added to cover using 'effective' properties for
calculation instead of normaliziations of the real ones.

Added cozy styles and set as default while the compact css vars are now
moved to sizes-parameters.css files.

Input event is now fixed and fired only after the current value is
changed by user interaction.

Updating the labels based on the other properties is fixed - labels are
now getting re-created if the one of the other component's properties is updated.

Tickmarks bug when sometimes the tickmars are hidden under the parent's
background is fixed, the tickmark DOM element no longer has a z-index
set to -1.
@ilhan007 ilhan007 merged commit 0cbc0bd into SAP:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants