fix(ui5-slider): add more tests, add cozy styles, fix input event, fix tickmarks display #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New tests are added to cover using 'effective' properties for calculation instead of normaliziations of the real ones. Added cozy styles and set as default while the compact css vars are now moved to sizes-parameters.css files. Input event is now fixed and fired only after the current value is changed by user interaction. Updating the labels based on the other properties is fixed - labels are now getting re-created if the one of the other component's properties is updated. Tickmarks bug when sometimes the tickmars are hidden under the parent's background is fixed, the tickmark DOM element no longer has a z-index set to -1.
ndeshev
force-pushed
the
sliders-tests-and-styles
branch
from
0e4e9dd
to
7d5e10b
Compare
ilhan007
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests are added to cover using 'effective' properties for
calculation instead of normalizations of the real ones.
Added cozy styles and set as default while the compact css vars are now
moved to sizes-parameters.css files.
Input event is now fixed and fired only after the current value is
changed by user interaction.
Updating the labels based on the other properties is fixed - labels are
now getting re-created if the one of the other component's properties is updated.
Tickmarks bug that sometimes the tickmarks get hidden under the parent's
background is fixed, the tickmarks DOM no longer has a z-index set to -1.