feat(ui5-list): introduce "growing" property #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the ui5-table, now the ui5-list provides growing property with 3 available options: - Button: Shows a "More" button at the bottom of the list pressing of which triggers the "load-more" event. - Scroll: The "load-more" event is triggered when the user scrolls to the bottom of the list. - None: growing is off BREAKING_CHANGES: infiniteScroll has been removed, use growing="Scroll" instead
|
For your information @sfsf-xweb-sh |
vladitasev
approved these changes
Mar 17, 2021
| */ | ||
| infiniteScroll: { | ||
| type: Boolean, | ||
| growing: { |
There was a problem hiding this comment.
1 space off, but don't lose the build for that
| this.unobserveListEnd(); | ||
| } | ||
|
|
||
| if (this.grows) { |
There was a problem hiding this comment.
this.grows or rather this.growsOnScroll? Do we need the resize listener for button mode?
There was a problem hiding this comment.
Maybe we do for the busy indicator. I think I got it
ilhan007
added a commit
that referenced
this pull request
Mar 17, 2021
Similar to the ui5-table, now the ui5-list provides growing property with 3 available options: Button, Scroll, None. As a side effect, it allows developers to set "max-height, overflow: auto" and the "load-more" still working as expected, fixing the referenced SF request #2882. Previously not possible as the List used to listen for the "scroll" of its internal container, which could not be influenced by these external styles. FIXES: #2882 BREAKING_CHANGES: The "infiniteScroll" property has been removed, use growing="Scroll" instead.
|
@MarcusNotheis FYI |
ilhan007
added a commit
that referenced
this pull request
Mar 18, 2021
Similar to the ui5-table, now the ui5-list provides growing property with 3 available options: Button, Scroll, None. As a side effect, it allows developers to set "max-height, overflow: auto" and the "load-more" still working as expected, fixing the referenced SF request #2882. Previously not possible as the List used to listen for the "scroll" of its internal container, which could not be influenced by these external styles. FIXES: #2882 BREAKING_CHANGES: The "infiniteScroll" property has been removed, use growing="Scroll" instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the ui5-table, now the ui5-list provides growing property with 3 available options:
pressing of which triggers the "load-more" event.
As a side effect, it allows developers to set "max-height, overflow: auto" and the "load-more" still working as expected,
fixing the referenced SF request #2882.
Previously not possible as the List used to listen for the "scroll" of its internal container, which could not be influenced by these external styles.
Testing
You can test the behavior with the following test pages:
ListGrowing_Button.html
ListGrowing_Scroll.html
FIXES: #2882
BREAKING_CHANGES: The "infiniteScroll" property has been removed, use growing="Scroll" instead.