Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transform css files to es6 modules #306

Merged
merged 1 commit into from
Apr 5, 2019
Merged

fix: transform css files to es6 modules #306

merged 1 commit into from
Apr 5, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Apr 5, 2019 •
edited
Loading

  • bundling without an additional setup for importing css files used to be broken
  • all css files are now distributed as modules that export a single string (css)
  • ui5-togglebutton used to override some css variables defined in the ui5-button

fix: transform css files to es6 modules
b3a2d51 
- all css files are now distributed as js modules that export a single string
- ui5-togglebutton used to override some css variables defined in the
ui5-button
@MapTo0 MapTo0 requested a review from pskelin April 5, 2019 10:20
@MapTo0 MapTo0 merged commit dbb98c8 into master Apr 5, 2019
@MapTo0 MapTo0 deleted the css-imports branch April 5, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pskelin pskelin pskelin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MapTo0 @pskelin