feat(ui5-shellbar): menuItems slot and menuItemPress event #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- menuItems renders list items in a popover which is might be open by clicking the primary title - menuItemPress is fired when a menu item is pressed - if no menu items are defined - no arrow down is rendered next to the primary title BREAKING CHANGE: titlePress event is removed and replaced by menuItems slot. FIXES: #290
MapTo0
force-pushed
the
shellbar-menu-items
branch
from
9ccba14
to
5b53730
Compare
MapTo0
changed the title
ilhan007
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: titlePress event is removed and replaced by menuItems slot.
FIXES: #290