Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds static method styles to base class #345

Merged
merged 2 commits into from
Apr 19, 2019
Merged

feat: adds static method styles to base class #345

merged 2 commits into from
Apr 19, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Apr 18, 2019

No description provided.

vladitasev
vladitasev reviewed Apr 19, 2019
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Approve, but I'll let the others have a look if they want to before submitting

ilhan007
ilhan007 reviewed Apr 19, 2019
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well

@MapTo0 MapTo0 merged commit b61860f into master Apr 19, 2019
@MapTo0 MapTo0 deleted the get-styles-static branch April 19, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev left review comments

@ilhan007 ilhan007 ilhan007 approved these changes

@pskelin pskelin Awaiting requested review from pskelin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MapTo0 @ilhan007 @vladitasev