Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-radiobutton): improve group handling #348

Merged
merged 7 commits into from
Apr 23, 2019
Merged

refactor(ui5-radiobutton): improve group handling #348

merged 7 commits into from
Apr 23, 2019

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Apr 19, 2019 •
edited
Loading

  • Added new property "name", which replaces the property "group" (removed with this change)
  • When selection changes within the group by user interaction - single "select" event is being fired and
    the newly selected radio button is the event target.
  • if more than one radio buttons within a group is set as selected, the last one is effectively selected.
  • if a ui5-radiobutton is added to a new group, the single selection rule would be applied.
  • if the selected state is programatically changed, the single selection rule is applied and no event is fired.

BREAKING CHANGE: the property "group" is replaced by the "name" property.

@ilhan007
wip(ui5-radio): improve group handling
a041efa 
All changes have neen performed to make the ui5 element behave as the native <input type="radio":
* if selection changes within the group - only one event is being fired and
the newly selected radio is the event target (previously multiple events used to be fired)
* if more than one radio within a group is set as selected, the last one is effectively selected
(previously more than one is visually selected, which breaks the group state)
* if dynamically a radiobutton is added to new group, single selection rule is also applied
(previously not handled)
* if the selected state is programatically changed, the group handling and single selection rule are kept
(previously not handled at all)
@ilhan007
fix eslint
1cbb51e
@ilhan007
change 'group' to 'name'
341a19b
@ilhan007 ilhan007 changed the title wip(ui5-radiobutton): improve group handling feat(ui5-radiobutton): add group handling support Apr 22, 2019
@ilhan007 ilhan007 changed the title feat(ui5-radiobutton): add group handling support feat(ui5-radiobutton): enable group handling Apr 22, 2019
@ilhan007 ilhan007 changed the title feat(ui5-radiobutton): enable group handling refactor(ui5-radiobutton): improve group handling Apr 22, 2019
@ilhan007 ilhan007 requested review from pskelin and MapTo0 April 22, 2019 13:53
@ilhan007 ilhan007 merged commit 4d7d9c3 into master Apr 23, 2019
@ilhan007 ilhan007 deleted the fix-radio-in-group branch April 23, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@pskelin pskelin Awaiting requested review from pskelin

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilhan007 @vladitasev