Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][SF][Urgent - Expect WithIn One Week][UI5-List] Ensure interactive controls are not nested #3927

Closed
sfsf-xweb-sh opened this issue Sep 15, 2021 · 2 comments · Fixed by #3952
Closed

[BUG][SF][Urgent - Expect WithIn One Week][UI5-List] Ensure interactive controls are not nested #3927

sfsf-xweb-sh opened this issue Sep 15, 2021 · 2 comments · Fixed by #3952
Assignees
@dobrinyonkov
Labels
SAP SF SF_ACC TOPIC P Very High Prio

Comments

@sfsf-xweb-sh
Copy link

Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team.
we use NVDA to test a11y issues in our project

Reproduce Step:
Open https://github.wdf.sap.corp/pages/xweb/assignment/app.html?mock#/assignment-detail/ao/2
Click the applicants tab

Bug Description
Ensure interactive controls are not nested reported by axe-core
nested control issue
@sfsf-xweb-sh sfsf-xweb-sh changed the title [BUG][SF][Urgent][UI5-List] Ensure interactive controls are not nested [BUG][SF][Urgent - Expect WithIn One Week][UI5-List] Ensure interactive controls are not nested Sep 15, 2021
@fifoosid fifoosid self-assigned this Sep 15, 2021
@fifoosid
Copy link
Contributor

fifoosid commented Sep 15, 2021 •
edited

FYI @SAP/ui5-webcomponents-topic-p

@fifoosid fifoosid removed their assignment Sep 15, 2021
@fifoosid fifoosid added TOPIC P and removed TOPIC RD labels Sep 15, 2021
@dobrinyonkov dobrinyonkov self-assigned this Sep 15, 2021
@ilhan007 ilhan007 mentioned this issue Sep 17, 2021
Closed
4 tasks
@dobrinyonkov dobrinyonkov mentioned this issue Sep 17, 2021
Merged
ilhan007 pushed a commit that referenced this issue Sep 20, 2021
@dobrinyonkov
fix(ui5-list): change role mappings so no interactive elements are ne… (
6d98d0c 
#3952)

Fixes: #3927

Issue: Interactive elements should not be nested inside element with role option.
There are nested interactive elements inside list items in selection mode - ui5-radio-button & ui5-checkbox.

Summary of changes:

the role mapping is changed from listbox -> option[] to list -> listitem[];
the selected state announcement is handled separately with aria-describedby as the listitem role does not support aria-selected;
aria-multiselectable is removed because it is not supported on the role list;
Note: aria-labelledby should not be used for the "Selected" & "Not Selected" texts as NVDA reads the whole value of the attribute when some of its references changes content. In this case - the whole content of the item.
ilhan007 pushed a commit that referenced this issue Sep 20, 2021
@dobrinyonkov @ilhan007
fix(ui5-list): change role mappings so no interactive elements are ne… (
82be1de 
#3952)

Fixes: #3927

Issue: Interactive elements should not be nested inside element with role option.
There are nested interactive elements inside list items in selection mode - ui5-radio-button & ui5-checkbox.

Summary of changes:

the role mapping is changed from listbox -> option[] to list -> listitem[];
the selected state announcement is handled separately with aria-describedby as the listitem role does not support aria-selected;
aria-multiselectable is removed because it is not supported on the role list;
Note: aria-labelledby should not be used for the "Selected" & "Not Selected" texts as NVDA reads the whole value of the attribute when some of its references changes content. In this case - the whole content of the item.
@ilhan007
Copy link
Member

Fixed with 0.31.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dobrinyonkov dobrinyonkov

Labels
SAP SF SF_ACC TOPIC P Very High Prio
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
5 participants
@ilhan007 @fifoosid @nikolay-kolarov @dobrinyonkov @sfsf-xweb-sh