-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][SF][Urgent - Expect WithIn One Week][UI5-List] Ensure interactive controls are not nested #3927
Labels
Comments
FYI @SAP/ui5-webcomponents-topic-p |
4 tasks
ilhan007
pushed a commit
that referenced
this issue
Sep 20, 2021
#3952) Fixes: #3927 Issue: Interactive elements should not be nested inside element with role option. There are nested interactive elements inside list items in selection mode - ui5-radio-button & ui5-checkbox. Summary of changes: the role mapping is changed from listbox -> option[] to list -> listitem[]; the selected state announcement is handled separately with aria-describedby as the listitem role does not support aria-selected; aria-multiselectable is removed because it is not supported on the role list; Note: aria-labelledby should not be used for the "Selected" & "Not Selected" texts as NVDA reads the whole value of the attribute when some of its references changes content. In this case - the whole content of the item.
ilhan007
pushed a commit
that referenced
this issue
Sep 20, 2021
#3952) Fixes: #3927 Issue: Interactive elements should not be nested inside element with role option. There are nested interactive elements inside list items in selection mode - ui5-radio-button & ui5-checkbox. Summary of changes: the role mapping is changed from listbox -> option[] to list -> listitem[]; the selected state announcement is handled separately with aria-describedby as the listitem role does not support aria-selected; aria-multiselectable is removed because it is not supported on the role list; Note: aria-labelledby should not be used for the "Selected" & "Not Selected" texts as NVDA reads the whole value of the attribute when some of its references changes content. In this case - the whole content of the item.
Fixed with 0.31.18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team.
we use NVDA to test a11y issues in our project
Reproduce Step:
Open https://github.wdf.sap.corp/pages/xweb/assignment/app.html?mock#/assignment-detail/ao/2
Click the applicants tab
Bug Description
![nested control issue](https://user-images.githubusercontent.com/78520316/133362785-d74e7dda-ca06-45b9-a719-20140c9544e8.png)
Ensure interactive controls are not nested
reported byaxe-core
The text was updated successfully, but these errors were encountered: