fix(ui5-list): change role mappings so no interactive elements are ne… #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you change the accessible-role default to "list", please update the Notification examples that currently set that value explicitly. Actually the property has been specifically introduced for the use case of notification list, so you might even make the property private if you prefer not to support it as public <ui5-list id="notificationList" header-text="Notifications grouped" accessible-role="list"> |
ilhan007
previously approved these changes
Sep 20, 2021
ilhan007
approved these changes
Sep 20, 2021
ilhan007
pushed a commit
that referenced
this pull request
Sep 20, 2021
#3952) Fixes: #3927 Issue: Interactive elements should not be nested inside element with role option. There are nested interactive elements inside list items in selection mode - ui5-radio-button & ui5-checkbox. Summary of changes: the role mapping is changed from listbox -> option[] to list -> listitem[]; the selected state announcement is handled separately with aria-describedby as the listitem role does not support aria-selected; aria-multiselectable is removed because it is not supported on the role list; Note: aria-labelledby should not be used for the "Selected" & "Not Selected" texts as NVDA reads the whole value of the attribute when some of its references changes content. In this case - the whole content of the item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3927
Issue: Interactive elements should not be nested inside element with role option.
There are nested interactive elements inside list items in selection mode -
ui5-radio-button&ui5-checkbox.Summary of changes:
listbox -> option[]tolist -> listitem[];aria-describedbyas thelistitemrole does not supportaria-selected;aria-multiselectableis removed because it is not supported on the rolelist;Note:
aria-labelledbychould not be used for the "Selected" & "Not Selected" texts as NVDA reads the whole value of the attribute when some of its references changes content. In this case - the whole content of the item.