Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-list): selectionChange event provides previousSelection items #418

Merged
merged 5 commits into from
May 22, 2019

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented May 21, 2019

Fixes #367

BREAKING CHANGE: the "selectionChange" event param "items" is renamed to "selectedItems".

@fifoosid fifoosid requested a review from ilhan007 May 21, 2019 08:05
vladitasev
vladitasev previously approved these changes May 21, 2019
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just hold on until we agree on the parameter name, then I will approve immediately

@ilhan007 ilhan007 dismissed their stale review May 21, 2019 13:41

agreed on param naming

@@ -177,6 +177,7 @@ const metadata = {
selectionChange: {
detail: {
items: { type: Array },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the API

selectedItems
previouslySelectedItems

@fifoosid fifoosid merged commit f0fc8f2 into master May 22, 2019
@fifoosid fifoosid deleted the list-selectionchange-params branch May 22, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-list selectionChange event to provide the previouslySelected item
3 participants