feat(ui5-busyindicator): introduce active property and simplify usage #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MapTo0
commented
Jun 6, 2019
MapTo0
commented
- busy indicator is invisible by default
- it can slot any content
- active property enables its visibility
- busy indicator is invisible by default - it can slot any content - active property sets its visibility
|
Fixes: #371 |
ilhan007
reviewed
Jun 6, 2019
| display: inline-block; | ||
| width: 100%; | ||
| height: 100%; | ||
| :host(ui5-busyindicator[active]) { |
There was a problem hiding this comment.
should we add the same for IE as well
ilhan007
reviewed
Jun 6, 2019
|
|
||
| <br/> | ||
| <br/> | ||
| <ui5-busyindicator size="Medium" active id="indicator2" hidden></ui5-busyindicator> |
There was a problem hiding this comment.
maybe we should remove the hidden and stick to active
ilhan007
previously approved these changes
Jun 7, 2019
ilhan007
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.