Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: access DOM in connectedCallback instead of constructor #524

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

vladitasev
Copy link
Contributor

When a custom element is created via "document.createElement", the browser throws an exception when compactSize=true, because DOM is accessed in the constructor, rather than in connectedCallback

@vladitasev vladitasev merged commit 0f3b8e4 into master Jun 10, 2019
@vladitasev vladitasev deleted the no-dom-access-in-constructor branch June 10, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants