fix: icon no longer flickers on IE #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IE CSS enters the head tag with setTimeout, because we schedule the CSS Vars ponyfill rather than run it immediately when CSS is available. The reason for this scheduling is that we need all CSS styles processed at once, otherwise it's too slow. We can't run the ponyfill for styles one by one due to the way it works (if you run it for just one style, the output will be for only this style, regardless of others processed earlier).
This is an icon-only solution until we have a framework-wide solution, because for icon the flicker is the worst, due to SVG scaling on IE. We create a global style in the head at define time and use it to hide the icon until it has entered the DOM.