Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon no longer flickers on IE #722

Merged
merged 1 commit into from
Aug 9, 2019
Merged

fix: icon no longer flickers on IE #722

merged 1 commit into from
Aug 9, 2019

Conversation

vladitasev
Copy link
Contributor

For IE CSS enters the head tag with setTimeout, because we schedule the CSS Vars ponyfill rather than run it immediately when CSS is available. The reason for this scheduling is that we need all CSS styles processed at once, otherwise it's too slow. We can't run the ponyfill for styles one by one due to the way it works (if you run it for just one style, the output will be for only this style, regardless of others processed earlier).

This is an icon-only solution until we have a framework-wide solution, because for icon the flicker is the worst, due to SVG scaling on IE. We create a global style in the head at define time and use it to hide the icon until it has entered the DOM.

@vladitasev vladitasev merged commit 964af67 into master Aug 9, 2019
@vladitasev vladitasev deleted the icon-ie-flicker branch August 9, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants