Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-badge): fix icon visual issue in ie #809

Merged
merged 5 commits into from
Oct 8, 2019
Merged

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Oct 1, 2019

No description provided.

@fifoosid fifoosid requested a review from ilhan007 October 1, 2019 12:02
@fifoosid fifoosid changed the title fix(ui5-badge): fix visual icon issue in ie fix(ui5-badge): fix icon visual issue in ie Oct 1, 2019
ilhan007
ilhan007 previously approved these changes Oct 1, 2019
}

/* IE 11 specific selector */
::slotted(.style-scope ui5-icon) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better just do ui5-badge ui5-icon[slot="icon"], should be the same and will not be applied in Chrome

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the following:
set font-size 2rem to ui5-badge, both the text and icon used to grow, but with this change only the text size increases.

@fifoosid fifoosid merged commit 150a100 into master Oct 8, 2019
@fifoosid fifoosid deleted the badge-icon-fix branch October 8, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants