-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-calendar): switch to two column layout on Islamic or Persian secondary calendar type #8453
Conversation
…an secondary calendar type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same issue isn't reproducible in openui5 project with Islamic secondary calendar type due to difference in the gridcell sizes. As you already mentioned the ui5-calendar
is the one that has gridcell sizes not according to the visual design. The issue is reproducible with the Persian secondary calendar type on both projects. We'll need to discuss the idea of the two column month layout with the visual designers as in this case a vertical scrolling appears:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine except the Home/End keyboard interactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things, when changing from month to year picker, there is a moving of the header of the calendar. The arrows and the button are going lower. Also when primary and secondary calendar are the same and are one of the exceptions, the calendar is still in 2 columns
…y calendar types are the same
The problem isn't introduced by the change. Outdated
Done ✅ EDIT: I was testing different case. There is actually header jump on two-column layout, so it will be fixed within this change. |
If you are not going to fix issue with current PR please reference issue where the issue could be tracked. |
…secondary calendar type (#8453) Now, when any of the two calendar types (Persian or Islamic) is set as a secondaryCalendarType, when the end user is in month view of the calendar, the months are displayed in two column layout, instead of three, providing enough space for the texts to be displayed in one row.
Previously when
secondaryCalendarType
was set toIslamic
orPersian
, the texts of the months' names didnt had enough space in the cell to be displayed on one row, which wasnt the desired behavior.Now, when any of those two calendar types is set as a
secondaryCalendarType
, when the end user is in month view of the calendar, the months are displayed in two column layout, instead of three, providing enough space for the texts to be displayed in one row.Tested in both Cozy/Compact modes in following scenarios:
Primary/SecondaryCalendarType:
Before
After
Fixes: #7712