feat(ui5-panel): implement accessibility #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
requested changes
Oct 18, 2019
|
|
||
| describe("Accessibility", () => { | ||
|
|
||
| it("tests whether aria attributes are set correctly without custom header", () => { |
There was a problem hiding this comment.
Regarding test 1:
- instead of "without custom header", call it "with native header"
- Here you should test the the button attributes are missing (as they should be passes as undefined)
- Rename those
Aria-expanded -> aria-expanded
Aria-controls -> aria-controls
Regarding test 2:
- instead of "in case of custom header" - "with custom header". Or use "in case of"in the first test name as well,
the point is to have consistent names as possible. - Here you should test the panel header attributes are missing (as they should be passes as undefined).
ilhan007
changed the title
ilhan007
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented accessibility for the ui5-panel.