Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-combobox): fix grouping sample #9085

Merged
merged 3 commits into from
May 31, 2024
Merged

fix(ui5-combobox): fix grouping sample #9085

merged 3 commits into from
May 31, 2024

Conversation

ndeshev
Copy link
Contributor

@ndeshev ndeshev commented May 30, 2024

fix grouping sample to use nested grouping

@ndeshev
fix(ui5-combobox): fix grouping sample
162d43c 
fix grouping sample to use nested grouping
@ndeshev ndeshev requested a review from ivoplashkov May 30, 2024 06:26
ivoplashkov
ivoplashkov requested changes May 30, 2024
View reviewed changes
Copy link
Member

@ivoplashkov ivoplashkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample is not loading at all..

Screenshot 2024-05-30 at 13 48 20

@ndeshev ndeshev merged commit 2c160d3 into main May 31, 2024
10 checks passed
@ndeshev ndeshev deleted the cb-grouping-sample branch May 31, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoplashkov ivoplashkov ivoplashkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndeshev @ivoplashkov