New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-option-custom): show focus outline #9101

Merged

ilhan007 merged 1 commit into main from sel-option

Jun 1, 2024

Member

ilhan007 commented Jun 1, 2024 •

edited

Loading

The selectors for focus outline don't match as the desktop attribute was missing, not set for the OptionCustom (as in the Option)

Before

Screenshot 2024-06-01 at 11 51 13

After

there is console error for missing dependency as the Option uses the Icon in its template


          fix(ui5-option-custom): show focus outline

3e8b2f5

ilhan007 requested review from nnaydenow and dobrinyonkov

June 1, 2024 09:25

nnaydenow approved these changes

View reviewed changes

ilhan007 merged commit bf8366e into main

10 checks passed

ilhan007 deleted the sel-option branch

June 1, 2024 09:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet