Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent throwing exception if slotted child does not have listenFor #92

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

adrian-bobev
Copy link
Member

Certain child should inform their parents for property change and make the parent invalidate.

This is done through a listenFor in the metadata. However, when two such components are used inside each other, the metadata for the inner one was get for the first time incorrectly (prop.target was wrong).

  • Now the correct element is used (this)
  • Early return is performed if for some reason the listenFor is empty (not needed for the fix)

This fixes the ui5-table inside a ui5-tabcontainer

@adrian-bobev adrian-bobev merged commit 4ffce64 into master Feb 27, 2019
@adrian-bobev adrian-bobev deleted the fix-child-updated branch February 27, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants