feat(ui5-label): add showColon property #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of issue #834
The asterisk marking the ui5-label as required is now positioned to the right side of the label text. A new property "showColon" was introduced for proper positioning and avoiding truncation of the "colon"
The asterisk marking the ui5-label as required is now positioned to the right side of the label text. A new property "showColon" was introduced for proper positioning and avoiding truncation of the "colon"
ilhan007
changed the title
|
Please check the failing tests |
The asterisk marking the ui5-label as required is now positioned to the right side of the label text. A new property "showColon" was introduced for proper positioning and avoiding truncation of the "colon"
ilhan007
reviewed
Nov 26, 2019
ilhan007
reviewed
Nov 26, 2019
ilhan007
requested changes
Nov 26, 2019
There was a problem hiding this comment.
When I comment those styles, I think the result is the same, but I might miss something.
Can you look at it?
/* :host([show-colon][required]) .label-required-colon {
display: inline-block;
line-height: 1rem;
vertical-align: top;
}
:host([show-colon][required]) .label-required-colon:before {
line-height: 1rem;
vertical-align: top;
} */Also, it`s good to add one new sample section within the Label.sample.html to show the new property in the official documentation. How to run locally the playground, you can reach @fifoosid .
ilhan007
changed the title
The asterisk marking the ui5-label as required is now positioned to the right side of the label text. A new property "showColon" was introduced for proper positioning and avoiding truncation of the "colon"
ilhan007
requested changes
Nov 27, 2019
The asterisk marking the ui5-label as required is now positioned to the right side of the label text. A new property "showColon" was introduced for proper positioning and avoiding truncation of the "colon"
ilhan007
requested changes
Nov 27, 2019
packages/main/src/themes/Label.css
Outdated
| :host([wrap]) .ui5-label-root { | ||
| white-space: normal; | ||
| line-height: 1.4rem; | ||
| :host(:not([wrap])) .label-text-wrapper { |
There was a problem hiding this comment.
Sorry I forgot to mention the new css classes does not follow the naming conventions:
Rename those:
.label-text-wrapper -> .ui5-label-text-wrapper
.label-required-colon -> .ui5-label-colon (it`s not only for required label right)
The asterisk marking the ui5-label as required is now positioned to the right side of the label text. A new property "showColon" was introduced for proper positioning and avoiding truncation of the "colon"
The asterisk marking the ui5-label as required is now positioned to the right side of the label text. A new property "showColon" was introduced for proper positioning and avoiding truncation of the "colon"
ilhan007
changed the title
The asterisk marking the ui5-label as required is now positioned to the right side of the label text. A new property "showColon" was introduced for proper positioning and avoiding truncation of the "colon"
ilhan007
approved these changes
Nov 27, 2019
ilhan007
added a commit
that referenced
this pull request
Nov 28, 2019
fix degradation caused by recent commit in the ui5 -label #965 resulting in a bug with the ui5-checkbox wrapping
ilhan007
added a commit
that referenced
this pull request
Nov 28, 2019
ilhan007
added a commit
that referenced
this pull request
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.