Bump minimum node version.
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this have been published as a new major version? It caused the generator-eslint build to start failing when I realize that Node v0.10 is now unsupported by the Node.js project, and we do plan to stop supporting it relatively soon, but dropping support for a Node version is a backwards-incompatible change and should result in a major version bump. |
|
@SBoudrias Any chance this could be reverted, published as 2.3.1, and then the commit can be re-applied and released as 3.0.0? Otherwise, we'll have to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now requires
node0.12 or greater. Dropspinkie-promise.