-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails on bootstrap variables #241
Comments
Hi @Janpot! Thanks for report, we are investigating how to fix this. Before this happens, you might be interested in how to exclude bootstrap (or other vendor styles) from the building process. If so, please check this paragraph https://github.com/SC5/sc5-styleguide#how-to-exclude-styles-from-source |
My bootstrap files are out of my build folder, I just copied the variables file to create my own theme, then noticed it doesn't build. FYI I added some failing tests to |
Did not noticed that you reported to Gonzales already and reported again :-) |
Ok, thanks. Just want to let you know the test case you presented there didn't fail for me when I tried it. It seems to only fail when it's on a function call. cheers. |
@Janpot In this case Gonzales test system understands that this is about arguments of functions and not about standalone braces. You can see this from other test cases related to arguments there: https://github.com/tonyganch/gonzales-pe/tree/dev/test/sass/arguments Their test system wraps these cases as "arguments" itself. |
Second issue is covered in PR tonyganch/gonzales-pe#46 |
Awesome! |
Tried to compile bootstrap-sass variables to a styleguide. The kss parser seems to choke on two occasions
first line (not sure why):
https://github.com/twbs/bootstrap-sass/blob/d3531a6fded02ba8ecd3e2d1f987927bd414883b/assets/stylesheets/bootstrap/_variables.scss#L4
also some functions are called with dubble parentheses, seems problematic for the parser as well
https://github.com/twbs/bootstrap-sass/blob/d3531a6fded02ba8ecd3e2d1f987927bd414883b/assets/stylesheets/bootstrap/_variables.scss#L57
The text was updated successfully, but these errors were encountered: