Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on bootstrap variables #241

Closed
Janpot opened this issue Nov 22, 2014 · 7 comments
Closed

Fails on bootstrap variables #241

Janpot opened this issue Nov 22, 2014 · 7 comments

Comments

@Janpot
Copy link
Contributor

Janpot commented Nov 22, 2014

Tried to compile bootstrap-sass variables to a styleguide. The kss parser seems to choke on two occasions

first line (not sure why):

$bootstrap-sass-asset-helper: (twbs-font-path("") != unquote('twbs-font-path("")')) !default;

https://github.com/twbs/bootstrap-sass/blob/d3531a6fded02ba8ecd3e2d1f987927bd414883b/assets/stylesheets/bootstrap/_variables.scss#L4

also some functions are called with dubble parentheses, seems problematic for the parser as well

$font-size-large: ceil(($font-size-base * 1.25)) !default; // ~18px

https://github.com/twbs/bootstrap-sass/blob/d3531a6fded02ba8ecd3e2d1f987927bd414883b/assets/stylesheets/bootstrap/_variables.scss#L57

@varya
Copy link
Contributor

varya commented Nov 24, 2014

Hi @Janpot! Thanks for report, we are investigating how to fix this. Before this happens, you might be interested in how to exclude bootstrap (or other vendor styles) from the building process. If so, please check this paragraph https://github.com/SC5/sc5-styleguide#how-to-exclude-styles-from-source

@Janpot
Copy link
Contributor Author

Janpot commented Nov 24, 2014

My bootstrap files are out of my build folder, I just copied the variables file to create my own theme, then noticed it doesn't build. FYI I added some failing tests to gonzales-pe yesterday about this issue tonyganch/gonzales-pe#42

@varya
Copy link
Contributor

varya commented Nov 24, 2014

Did not noticed that you reported to Gonzales already and reported again :-)
I fixed first issue with this PR tonyganch/gonzales-pe#45 Let's wait them to merge.
The second one also looks doable, I am fixing it right now.

@Janpot
Copy link
Contributor Author

Janpot commented Nov 24, 2014

Ok, thanks. Just want to let you know the test case you presented there didn't fail for me when I tried it. It seems to only fail when it's on a function call. cheers.

@varya
Copy link
Contributor

varya commented Nov 24, 2014

@Janpot In this case Gonzales test system understands that this is about arguments of functions and not about standalone braces. You can see this from other test cases related to arguments there: https://github.com/tonyganch/gonzales-pe/tree/dev/test/sass/arguments Their test system wraps these cases as "arguments" itself.

@varya
Copy link
Contributor

varya commented Nov 24, 2014

Second issue is covered in PR tonyganch/gonzales-pe#46

@Janpot
Copy link
Contributor Author

Janpot commented Nov 24, 2014

Awesome!

@hannu hannu closed this as completed in ecdd928 Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants