Add form error messages #675

khainl1110 · 2020-10-27T00:50:00Z

Added messages to user if they left any input fields empty or invalid
Resolves #660

aashrav

Looks good. Just remove the unnecessary lines I mentioned below

src/Pages/MembershipApplication/MembershipForm.js

aashrav

Dope

src/Pages/MembershipApplication/MembershipForm.js

IsitaB

Change the way you handle invalid emails.

src/Pages/MembershipApplication/MembershipForm.js

law-nguyen

Make sure you address the other comments and then rebase your code.

khainl1110 · 2020-11-05T18:59:51Z

The Travis bot keeps saying "Some checks haven't completed yet" and "Expected - Waiting for status to be reported". Can you help me out with that, thanks! I tried git push force but nothing changed.

IsitaB

All tests succeed

jerrylee17 · 2020-11-20T03:47:23Z

jerrylee17

In addition to the email check, probably add a confirm password option

src/Pages/MembershipApplication/MembershipForm.js

khainl1110 · 2020-11-26T02:12:26Z

This error is in verification_js, which I'm not working on

seemavora

branch needs to be updated!

khainl1110 · 2021-01-11T06:59:43Z

Can you elaborate?

seemavora · 2021-01-11T07:05:47Z

it says that your branch is 7 commits behind dev, meaning your branch is out of date. Checkout wiki for the steps to rebase, if its your first time me or isita can help you!

khainl1110 · 2021-01-11T07:07:09Z

oh ok, I will look into the wiki first and try to do it. Thanks

khainl1110 · 2021-01-11T21:41:30Z

Branch rebased

charlotte-zhuang

There are some errors.

src/Pages/MembershipApplication/MembershipForm.js

Co-authored-by: charlotte <61573792+charlotte-zhuang@users.noreply.github.com>

…t/Core-v4 into membershipFormBug

khainl1110 · 2021-04-19T02:51:24Z

I changed code as requested, thanks

charlotte-zhuang

Check comments. PS it's nice to have a space before parentheses for non-functions like if () and before curly braces like function foo() {

The form isn't working either. Invalid password/email messages don't appear, and nothing happens when all input is valid.

I think it could help to simplify your name and account fields to have a checkRequirements attribute that points to a function to check requirements. If requirements are met, return { pass: true }. If requirements are not met, return { pass: false, message: message here }. Or something like that.

src/Pages/MembershipApplication/MembershipForm.js

Co-authored-by: charlotte <61573792+charlotte-zhuang@users.noreply.github.com>

khainl1110 · 2021-04-23T04:19:46Z

Fix some bugs

I think it could help to simplify your name and account fields to have a checkRequirements attribute that points to a function to check requirements. If requirements are met, return { pass: true }. If requirements are not met, return { pass: false, message: message here }. Or something like that.

There's addon and ifRequirementsNotMet, somebody before me did the addon part and I think it's meant to appear after the user click the submitted button, while ifRequirementsNotMet is for when user is filling out the form. I still don't get the 'checkRequirements' attribute part, like all of them point to a single function?

1. Removed addon attribute 2. Changed when alert messages appear 3. Fixed password validation 4. Make password requirements clearer

1. Changed submit button to type="submit" 2. Added Form component 3. There's a bug in Firefox where you can't scroll when a password field is selected. This might not be our problem as changing the input type to text fixes the issue.

charlotte-zhuang

sorry, I went and just made the changes that still needed to be made

Changes

Fixed a few bugs
Removed addon attribute from form
Changed invalid alerts to only show after user clicks submit
Added more detailed password requirement feedback
Wrapped the entire form in a Form component to allow users to submit with enter

Issues

Firefox can't scroll when a password field is selected. Changing type="text" fixes the issue for some reason (but is undesirable).
Some links and buttons aren't in the tab order. Adding tabindex="0" and role="tablist", role="tab" didn't change anything.

Pictures

khainl1110 · 2021-04-27T04:33:58Z

thanks for improving the code, @charlotte-zhuang!

charlotte-zhuang · 2021-05-08T18:18:59Z

@khainl1110 I think you can merge this PR.

khainl1110 · 2021-05-08T20:04:50Z

@charlotte-zhuang it said merging is blocked for me, can you or someone do it instead? Thanks

khainl1110 requested review from IsitaB, aashrav, jerrylee17 and ThaiQ October 27, 2020 00:50

khainl1110 self-assigned this Oct 27, 2020

aashrav requested review from law-nguyen and hsorathia October 28, 2020 00:45

aashrav requested changes Oct 28, 2020

View reviewed changes

aashrav approved these changes Oct 28, 2020

View reviewed changes

jerrylee17 requested changes Nov 3, 2020

View reviewed changes

src/Pages/MembershipApplication/MembershipForm.js Outdated Show resolved Hide resolved

src/Pages/MembershipApplication/MembershipForm.js Outdated Show resolved Hide resolved

src/Pages/MembershipApplication/MembershipForm.js Outdated Show resolved Hide resolved

IsitaB requested changes Nov 3, 2020

View reviewed changes

src/Pages/MembershipApplication/MembershipForm.js Outdated Show resolved Hide resolved

src/Pages/MembershipApplication/MembershipForm.js Outdated Show resolved Hide resolved

law-nguyen reviewed Nov 3, 2020

View reviewed changes

IsitaB approved these changes Nov 13, 2020

View reviewed changes

jerrylee17 self-requested a review November 18, 2020 21:45

jerrylee17 requested changes Nov 20, 2020

View reviewed changes

src/Pages/MembershipApplication/MembershipForm.js Outdated Show resolved Hide resolved

src/Pages/MembershipApplication/MembershipForm.js Outdated Show resolved Hide resolved

jerrylee17 approved these changes Nov 26, 2020

View reviewed changes

Christopher-Tom force-pushed the membershipFormBug branch from 719b452 to 2c20523 Compare December 18, 2020 04:25

seemavora reviewed Jan 11, 2021

View reviewed changes

khainl1110 force-pushed the membershipFormBug branch 2 times, most recently from 0a52d23 to f170478 Compare January 11, 2021 21:30

ThaiQ force-pushed the dev branch 3 times, most recently from c0254c4 to 871c99d Compare January 25, 2021 00:02

khainl1110 added 4 commits April 8, 2021 08:03

Fixing some bugs

42dcf6d

Fixing Bugs

a8de361

Fixing bugs

7791cfb

Add confirm password and new regex to check email

bc87f25

khainl1110 force-pushed the membershipFormBug branch from f170478 to bc87f25 Compare April 8, 2021 15:03

charlotte-zhuang requested changes Apr 13, 2021

View reviewed changes

khainl1110 and others added 5 commits April 12, 2021 21:36

Update src/Pages/MembershipApplication/MembershipForm.js

70819c6

Co-authored-by: charlotte <61573792+charlotte-zhuang@users.noreply.github.com>

Update src/Pages/MembershipApplication/MembershipForm.js

1f8bf42

Co-authored-by: charlotte <61573792+charlotte-zhuang@users.noreply.github.com>

Update src/Pages/MembershipApplication/MembershipForm.js

1e37933

Co-authored-by: charlotte <61573792+charlotte-zhuang@users.noreply.github.com>

Implement changes requested

2e29d14

Merge branch 'membershipFormBug' of https://github.com/SCE-Developmen…

70055f6

…t/Core-v4 into membershipFormBug

khainl1110 requested a review from charlotte-zhuang April 16, 2021 03:16

charlotte-zhuang requested changes Apr 20, 2021

View reviewed changes

khainl1110 and others added 3 commits April 22, 2021 20:28

Update src/Pages/MembershipApplication/MembershipForm.js

5edd066

Co-authored-by: charlotte <61573792+charlotte-zhuang@users.noreply.github.com>

Update src/Pages/MembershipApplication/MembershipForm.js

0ab0dc9

Co-authored-by: charlotte <61573792+charlotte-zhuang@users.noreply.github.com>

Fix bugs, now prompt error messages while typing

0604b79

khainl1110 and others added 4 commits April 22, 2021 21:20

Fix lint error

4fe0b6b

Fixed error messages

e921d84

1. Removed addon attribute 2. Changed when alert messages appear 3. Fixed password validation 4. Make password requirements clearer

Submit on enter

ad7f34a

1. Changed submit button to type="submit" 2. Added Form component 3. There's a bug in Firefox where you can't scroll when a password field is selected. This might not be our problem as changing the input type to text fixes the issue.

Changed alerts from to 

3014f86

charlotte-zhuang approved these changes Apr 27, 2021

View reviewed changes

charlotte-zhuang requested review from aashrav and IsitaB April 27, 2021 04:31

charlotte-zhuang merged commit 0b61096 into dev May 8, 2021

charlotte-zhuang deleted the membershipFormBug branch May 8, 2021 20:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add form error messages #675

Add form error messages #675

khainl1110 commented Oct 27, 2020

aashrav left a comment

aashrav left a comment

IsitaB left a comment

law-nguyen left a comment

khainl1110 commented Nov 5, 2020 •

edited

Loading

IsitaB left a comment

jerrylee17 commented Nov 20, 2020

jerrylee17 left a comment

khainl1110 commented Nov 26, 2020

seemavora left a comment

khainl1110 commented Jan 11, 2021

seemavora commented Jan 11, 2021 •

edited

Loading

khainl1110 commented Jan 11, 2021

khainl1110 commented Jan 11, 2021

charlotte-zhuang left a comment

khainl1110 commented Apr 19, 2021

charlotte-zhuang left a comment

khainl1110 commented Apr 23, 2021

charlotte-zhuang left a comment

khainl1110 commented Apr 27, 2021 •

edited

Loading

charlotte-zhuang commented May 8, 2021

khainl1110 commented May 8, 2021

Add form error messages #675

Add form error messages #675

Conversation

khainl1110 commented Oct 27, 2020

aashrav left a comment

Choose a reason for hiding this comment

aashrav left a comment

Choose a reason for hiding this comment

IsitaB left a comment

Choose a reason for hiding this comment

law-nguyen left a comment

Choose a reason for hiding this comment

khainl1110 commented Nov 5, 2020 • edited Loading

IsitaB left a comment

Choose a reason for hiding this comment

jerrylee17 commented Nov 20, 2020

jerrylee17 left a comment

Choose a reason for hiding this comment

khainl1110 commented Nov 26, 2020

seemavora left a comment

Choose a reason for hiding this comment

khainl1110 commented Jan 11, 2021

seemavora commented Jan 11, 2021 • edited Loading

khainl1110 commented Jan 11, 2021

khainl1110 commented Jan 11, 2021

charlotte-zhuang left a comment

Choose a reason for hiding this comment

khainl1110 commented Apr 19, 2021

charlotte-zhuang left a comment

Choose a reason for hiding this comment

khainl1110 commented Apr 23, 2021

charlotte-zhuang left a comment

Choose a reason for hiding this comment

Changes

Issues

Pictures

khainl1110 commented Apr 27, 2021 • edited Loading

charlotte-zhuang commented May 8, 2021

khainl1110 commented May 8, 2021

khainl1110 commented Nov 5, 2020 •

edited

Loading

seemavora commented Jan 11, 2021 •

edited

Loading

khainl1110 commented Apr 27, 2021 •

edited

Loading