Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ospray: Latvol Fix and Camera Optimization #2287

Merged
merged 4 commits into from
Jul 30, 2021

Conversation

tarkpate
Copy link
Contributor

@tarkpate tarkpate commented Jun 4, 2021

This fits with issue #1949, but probably shouldn't close it.

The latvol construction for ospray had 2 problems that I fixed:

  • The y position of the origin was not set
  • The dimensions needed to be reduced by 1 to calculate spacing

The reason for the spacing change is that there is 1 less segment of space than there are boundaries. For example, a latvol with dimension 5 along an axis would have nodes at [0, 1, 2, 3, 4], but the ranges of spacing would be [0-1, 1-2, 2-3, 3-4], which has 4 segments of space.

The camera data was being recomputed before accruing every frame, so I saved camera object for reuse.

@dcwhite dcwhite requested review from dcwhite and jessdtate June 4, 2021 20:15
@dcwhite dcwhite self-assigned this Jun 4, 2021
@dcwhite dcwhite added the Ospray label Jun 4, 2021
@dcwhite dcwhite added this to To do in Ospray Integration via automation Jun 4, 2021
@dcwhite dcwhite added this to the 5.0-beta.ϴ [Internal] milestone Jun 4, 2021
dcwhite
dcwhite previously approved these changes Jun 4, 2021
This was referenced Jun 22, 2021
@tarkpate tarkpate changed the title Ospray Latvol Fix and Camera Optimization Ospray: Latvol Fix and Camera Optimization Jul 5, 2021
@dcwhite
Copy link
Member

dcwhite commented Jul 14, 2021

QObject::connect: No such slot SCIRun::Gui::OsprayViewerDialog::setWidth(igeomDataTransientnt)
QObject::connect:  (sender name:   'viewerWidthSpinBox_')
QObject::connect:  (receiver name: 'OsprayViewer')

@dcwhite
Copy link
Member

dcwhite commented Jul 14, 2021

Also, I get a crash when OsprayViewer is deleted. Please check that all cleanup is done in the destructor.

@dcwhite dcwhite self-requested a review July 14, 2021 15:07
@dcwhite
Copy link
Member

dcwhite commented Jul 14, 2021

OK the destructor crash can be fixed with a change in ModuleWidget.cc, around line 363:

isViewScene_(name == "ViewScene") //TODO

remove the check for name == "OsprayViewer". There's some extra code that gets confused now related to window position saving. Please add this to this PR @RubioJr9

@dcwhite dcwhite merged commit d0c08dd into SCIInstitute:master Jul 30, 2021
Ospray Integration automation moved this from To do to Done Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants