Ospray: Latvol Fix and Camera Optimization #2287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fits with issue #1949, but probably shouldn't close it.
The latvol construction for ospray had 2 problems that I fixed:
The reason for the spacing change is that there is 1 less segment of space than there are boundaries. For example, a latvol with dimension 5 along an axis would have nodes at [0, 1, 2, 3, 4], but the ranges of spacing would be [0-1, 1-2, 2-3, 3-4], which has 4 segments of space.
The camera data was being recomputed before accruing every frame, so I saved camera object for reuse.