-
Notifications
You must be signed in to change notification settings - Fork 8
Starting channel number not available for Custom Filter #33
Comments
BTW Go dev here and I have some fixes in my repo for PPV filtering |
@Fyb3roptik both of our forks has relatively large amount of code rewritten or changed and are pretty different, it's hard to just pick a change from yours without breaking something in mine 🤕 Thought maybe it's better to create a new issue here with description of a feature you would like to see in this one and I would refer to your fork to grab some code pieces (mentioning your work course!). P.S: Will make a new build with this issue closed soon. ~ In a hour. |
Haha yeah I'll get a PR going in your stuff. I did notice a weird issue where I couldn't edit a mapping by clicking on it |
@Fyb3roptik do you mean these table rows? Weirdly on my side its working fine, maybe try with https://github.com/SCP002/xTeVe/releases/tag/2.4.1.0000 + check the browser console if it's saying something. |
It's only when I use custom filter instead of group |
Do you want to put this repo in a new org and possibly rebrand xteve2 or something? |
TL;DR: No, don't see a reason to, but will gladly listen to people's arguments, so I could if you want. My roadmap is to, well, close these three: #35 #36 #38 (this one half done ATM, at least it looks like it is 🙃), in a next few days (depending on my free time etc.), upload the final release and archive this repository, because soon I'll switch to another project and it would be unfair to let people waste time on submitting new issues etc. which I'll never touch in the future ( ._.) Why so: P.S: Forgive my English. |
Would you mind if after that happens I fork it into its own project? Obviously would have all credits in place |
Sure! Moreover, credits are not mandatory: you are completely free to do whatever you want to do :) |
No sir! I give credit where it's due! That's what makes this community great! |
The text was updated successfully, but these errors were encountered: