Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker push CI #74

Closed
2 of 3 tasks
cmdoret opened this issue Oct 12, 2023 · 5 comments · Fixed by #90
Closed
2 of 3 tasks

Fix docker push CI #74

cmdoret opened this issue Oct 12, 2023 · 5 comments · Fixed by #90
Assignees
Labels
bug Something isn't working

Comments

@cmdoret
Copy link
Member

cmdoret commented Oct 12, 2023

the docker build and push CI workflow fails with:

#24 2.746 OSError: libgomp.so.1: cannot open shared object file: No such file or directory

Objective: Fix CI

Requirements:

  • Investigate issue in logs
  • Update Dockerfile as required
  • Trigger image push
@cmdoret cmdoret added the bug Something isn't working label Oct 12, 2023
@supermaxiste supermaxiste mentioned this issue Oct 17, 2023
@supermaxiste
Copy link
Member

Source of the issue from here. For the last point, I can't trigger the push myself.

@cmdoret cmdoret linked a pull request Oct 17, 2023 that will close this issue
@supermaxiste
Copy link
Member

supermaxiste commented Oct 18, 2023

Looks like there's an OS incompatibility issue:

Unable to find installation candidates for typecode-libmagic (5.39.210531)

Next steps:

  • Check alternative options to keep arm64 architecture
  • If yes to point above: consider if it's worth the effort
  • If no, discuss dropping the architecture or the dependency

@cmdoret
Copy link
Member Author

cmdoret commented Oct 18, 2023

Insights so far:

  • scancode-toolkit ships with typecode-libmagic, a binary python package with an optimized libmagic. It is fast, but not arm64-compatible
  • scancode-toolkit-mini does not ship typecode-libmagic and can use the system's libmagic. It works on any platform, but is very slow

EDIT: both versions might actually be equally slow

@supermaxiste
Copy link
Member

Shall we can keep the toolkit as is and fix the docker push for this issue?
For optimizing the scancode-toolkit we can open a separate issue, what do you think?

@cmdoret
Copy link
Member Author

cmdoret commented Oct 18, 2023

Agreed, optimizing would likely be replacing: for which there is now this issue: #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants