Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SHA for all actions with version in comments #38

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

supermaxiste
Copy link
Member

@supermaxiste supermaxiste commented Mar 1, 2023

Github made a major change in actions in October 2022 that deprecated some commands for Actions and will cause them to fail automatically from April 2023 if not updated. Currently gimie is using some old actions (Docker login, Docker extract metadata and Docker Build and Push) that trigger the following warnings:

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Because of this I updated the SHA from the old actions but also the ones not triggering warnings. I added as comments the release versions to make it easier to understand the SHA source.

@supermaxiste supermaxiste requested a review from marftn March 1, 2023 09:55
Copy link
Member

@marftn marftn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I somehow missed this PR.
Looks good to me 👍

@supermaxiste supermaxiste merged commit 184f821 into main Mar 29, 2023
@cmdoret cmdoret deleted the update_actions branch March 29, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants