Make note event row height dynamic #3952
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
NoteEvents are set up as a single line
ui-grid
. If a Note text exceeds the screen width it will be truncated with a '...'. (It is copyable with a triple click).What's this PR do?
Attempts to make the ui-grid row height dynamic. Initial research suggests that
ui-grid
rowHeights
cannot be set automatically (reference).rowHeight
can be dynamically set with a function.where 25 is the height of a single line and 180 is a rough estimate of number of characters per line on a 1440 px screen (13 inch MacBook). The function could be improved if screen width was taken into consideration.
Alternative Solutions
Instead of working to get row height to be dynamic, we could post a link to the full note on the notes page.
Ultimately this is in need of a more elegant solution
How should this be manually tested?
What are the relevant tickets?
Screenshots (if appropriate)
Old
New