-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AT submission import #4620
Merged
Merged
Add AT submission import #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryr16
added
DO NOT MERGE
Feature
Add this label to new features. This will be reflected in the change log when generated.
labels
Apr 10, 2024
…latform/seed into 4544-AT-submission-import
…latform/seed into 4544-AT-submission-import
kflemin
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆🏆🏆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Add this label to new features. This will be reflected in the change log when generated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Sharing buildings between admins and users on Audit Template is non trivial. Resulting imports from AT might not contain all relevent buildings to the user. The existing city submission endpoint circumvents this issue.
What's this PR do?
batch_get_city_submission_xml
function. This is the driving function behind the new functionality, and it performs the following:batch_update_with_building_sync
in cycle batches.audit_template_city_id
,audit_template_sync_enabled
,audit_template_status_type
, andaudit_template_conditional_input
Limitations and Potential Issues
audit_template_conditional_input
boolean is checked, matches will be limited to those with AT 'updated_at' more recent than SEED 'updated_at '.How should this be manually tested?
This can only be tested with an Audit Template account that has submissions. Example: 179D AT account.
CONFIGURATION
Custom ID 1
s to the Portal IDs on Audit Template cities pageIMPORT FROM AT
AUTO SYNC
What are the relevant tickets?
#4544
Screenshots (if appropriate)