Skip to content

Commit

Permalink
libsepol/cil: cil_reset_classperms_set() should not reset classpermis…
Browse files Browse the repository at this point in the history
…sion

In struct cil_classperms_set, the set field is a pointer to a
struct cil_classpermission which is looked up in the symbol table.
Since the cil_classperms_set does not create the cil_classpermission,
it should not reset it.

Set the set field to NULL instead of resetting the classpermission
that it points to.

Signed-off-by: James Carter <jwcart2@gmail.com>
  • Loading branch information
jwcart2 committed Apr 19, 2021
1 parent 2d35fcc commit c49a8ea
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion libsepol/cil/src/cil_reset_ast.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,11 @@ static void cil_reset_classpermission(struct cil_classpermission *cp)

static void cil_reset_classperms_set(struct cil_classperms_set *cp_set)
{
cil_reset_classpermission(cp_set->set);
if (cp_set == NULL) {
return;
}

cp_set->set = NULL;
}

static inline void cil_reset_classperms_list(struct cil_list *cp_list)
Expand Down

0 comments on commit c49a8ea

Please sign in to comment.