libsepol: fix endianity in ibpkey range checks #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to convert from little-endian before dong range checks on the ibpkey port numbers, otherwise we would be checking a wrong value on big-endian systems. Fixes: 9fbb311 ("libsepol: Add ibpkey ocontext handling") Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
williamcroberts
force-pushed
the
fix-ibpkey-range-checks
branch
from
5ba2214
to
f387ad6
Compare
The kernel checks if the port is in the range 1-255 when loading an ibenportcon rule. Add the same check to libsepol. Fixes: 118c0cd ("libsepol: Add ibendport ocontext handling") Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to convert from little-endian before dong range checks on the
ibpkey port numbers, otherwise we would be checking a wrong value.
Fixes: 9fbb311 ("libsepol: Add ibpkey ocontext handling")
Acked-by: William Roberts william.c.roberts@intel.com
Acked-by: Stephen Smalley sds@tycho.nsa.gov
Signed-off-by: Ondrej Mosnacek omosnace@redhat.com