Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change benchmark unit of time from nanoseconds to seconds #88

Closed
qxzzxq opened this issue Jan 28, 2020 · 0 comments
Closed

Change benchmark unit of time from nanoseconds to seconds #88

qxzzxq opened this issue Jan 28, 2020 · 0 comments
Labels
enhancement Enhancement of an existing feature good first issue Good for newcomers
Projects
SETL Dev

Comments

@qxzzxq
Copy link
Member

qxzzxq commented Jan 28, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
The actual benchmark message use nanosecond as the unit of time, which doesn't fit our use case as ETL workflow often lasts much longer.

Describe the solution you'd like
In com.jcdecaux.setl.internal.BenchmarkInvocationHandler, use seconds to measure the elapsed time.
@qxzzxq qxzzxq added good first issue Good for newcomers enhancement Enhancement of an existing feature labels Jan 28, 2020
@qxzzxq qxzzxq added this to To do in SETL Dev via automation Jan 28, 2020
@JorisTruong JorisTruong self-assigned this Jan 29, 2020
@qxzzxq qxzzxq closed this as completed in 8db3f73 Jan 29, 2020
SETL Dev automation moved this from To do to Done Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement of an existing feature good first issue Good for newcomers
Projects
No open projects
SETL Dev
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qxzzxq @JorisTruong