Cleanup some warnings #3491

prescod · 2023-01-16T22:08:38Z

Cleanup a few warnings. I'll use comments to explain.

prescod · 2023-05-09T22:06:49Z

.prettierignore

Don't bother prettying Cassettes

prescod · 2023-05-09T22:08:24Z

cumulusci/core/config/org_config.py

@@ -204,7 +205,15 @@ def user_id(self):

    @property
    def org_id(self):
-        return self.id.split("/")[-2]
+        try:


This code probably relied previously on implicit None for config objects which is evil.

prescod · 2023-05-09T22:08:54Z

cumulusci/core/config/org_config.py

@@ -254,7 +263,7 @@ def populate_expiration_date(self):
    @property
    def organization_sobject(self):
        """Cached copy of Organization sObject. Does not perform API call."""
-        return self._org_sobject
+        return getattr(self, "_org_sobject", None)


This code probably relied previously on implicit None for config objects which is evil.

prescod · 2023-05-09T22:09:13Z

cumulusci/core/config/tests/test_config.py

@@ -66,7 +66,7 @@ def test_getattr_toplevel_key_missing(self):
            assert config.foo is None
        with mock.patch(
            "cumulusci.core.config.base_config.STRICT_GETATTR", True
-        ), pytest.raises(AssertionError):
+        ), pytest.deprecated_call(), pytest.raises(AssertionError):


Capture a deprecated call.

prescod · 2023-05-09T22:09:35Z

cumulusci/core/dependencies/tests/test_dependencies.py

@@ -645,6 +645,7 @@ def test_install(self, api_deploy_mock, zip_builder_mock, download_mock):
        assert mock_task.project_config == context

        api_deploy_mock.return_value.assert_called_once()
+        zf.close()


Close a file explicitly.

prescod · 2023-05-09T22:15:26Z

cumulusci/tasks/apex/tests/test_apex_tasks.py

-            responses.GET, url, match_querystring=True, json=expected_response
+            responses.GET,
+            url,
+            match=[query_string_matcher(query_string)],


Deprecate match_querystring argument in Response and CallbackResponse.
Use responses.matchers.query_param_matcher or responses.matchers.query_string_matcher

prescod · 2023-05-09T22:16:42Z

cumulusci/tasks/apex/tests/test_apex_tasks.py

        )

    def _get_mock_testqueueitem_status_query_url(self, job_id):
        return (
-            self.base_tooling_url
-            + f"query/?q=SELECT+Id%2C+Status%2C+ExtendedStatus%2C+ApexClassId+FROM+ApexTestQueueItem+WHERE+ParentJobId+%3D+%27{job_id}%27+AND+Status+%3D+%27Failed%27"
+            (self.base_tooling_url + "query/"),


Switch to query_string_matcher

prescod · 2023-05-09T22:18:27Z

cumulusci/tasks/bulkdata/tests/test_snowfakery.py

@@ -783,12 +783,11 @@ def test_explicit_channel_declarations(self, mock_load_data, create_task):
                "recipe": Path(__file__).parent
                / "snowfakery/simple_snowfakery.recipe.yml",
                "run_until_recipe_repeated": 15,
-                "recipe_options": {"xyzzy": "Nothing happens", "some_number": 42},


This was cut and paste from elsewhere and didn't need to be tested over and over.

prescod · 2023-05-09T22:18:34Z

cumulusci/tasks/bulkdata/tests/test_snowfakery.py

@@ -833,7 +832,6 @@ def test_serial_mode(self, mock_load_data, create_task):
                "recipe": Path(__file__).parent
                / "snowfakery/simple_snowfakery.recipe.yml",
                "run_until_recipe_repeated": 15,
-                "recipe_options": {"xyzzy": "Nothing happens", "some_number": 42},


This was cut and paste from elsewhere and didn't need to be tested over and over.

prescod · 2023-05-09T22:23:37Z

cumulusci/tasks/release_notes/parser.py

@@ -186,7 +186,7 @@ class GithubIssuesParser(IssuesParser):

    def __new__(cls, release_notes_generator, title, issue_regex=None):
        if not release_notes_generator.has_issues:
-            logging.getLogger(__file__).warn(
+            logging.getLogger(__file__).warning(


As of Python 3.3, logger.warn has been deprecated and logger.warning must be used. Even though logger.warn is still backwards compatible, you should not use it.

salesforce-cla · 2024-01-26T16:58:59Z

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Paul Prescod <p***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

prescod requested a review from a team as a code owner January 16, 2023 22:08

Paul Prescod added 4 commits January 17, 2023 11:10

Cleanup some warnings

ea016ac

Cleanup various warnings

49c5d26

Clean up more warnings

ad53e80

Cleanup OAuth Warnings

b486754

prescod added the ignore-for-release Don't include in release notes label Jan 17, 2023

Merge remote-tracking branch 'origin/main' into cleanup-warnings

70edc91

prescod force-pushed the cleanup-warnings branch from b9156fd to 70edc91 Compare January 21, 2023 17:07

Merge branch 'main' into cleanup-warnings

2bdb8cf

prescod commented May 9, 2023

View reviewed changes

Paul Prescod and others added 3 commits May 9, 2023 15:25

Merge remote-tracking branch 'origin/main' into cleanup-warnings

198027b

Remove extra import

00d2bb0

Merge branch 'main' into cleanup-warnings

e7915db

salesforce-cla bot added the cla:missing label Jan 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup some warnings #3491

Cleanup some warnings #3491

prescod commented Jan 16, 2023

prescod May 9, 2023

prescod May 9, 2023

prescod May 9, 2023

prescod May 9, 2023

prescod May 9, 2023

prescod May 9, 2023

prescod May 9, 2023

prescod May 9, 2023

prescod May 9, 2023

prescod May 9, 2023

salesforce-cla bot commented Jan 26, 2024

Cleanup some warnings #3491

Are you sure you want to change the base?

Cleanup some warnings #3491

Conversation

prescod commented Jan 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

salesforce-cla bot commented Jan 26, 2024