Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding a Default RenderState #178

Closed
eXpl0it3r opened this issue Dec 30, 2022 · 1 comment · Fixed by #180
Closed

Consider adding a Default RenderState #178

eXpl0it3r opened this issue Dec 30, 2022 · 1 comment · Fixed by #180
Labels
Feature

Comments

@eXpl0it3r
Copy link
Member

It's currently unclear what a default RenderState would look like, so it might make sense to have a default RenderState that can be used as basis and then modified as need be.

See discussion thread here (and here).
@Bqleine
Copy link
Contributor

Bqleine commented Jan 5, 2023

See discussion thread here (and here).

Oh hey that's me! I'm gonna try to implement it tonight.

Bqleine added a commit to Bqleine/CSFML that referenced this issue Jan 5, 2023
@Bqleine
Add function for default RenderState (SFML#178)
d0890c6
@eXpl0it3r eXpl0it3r linked a pull request Jan 5, 2023 that will close this issue
Add function for default RenderState (#178) #180
Merged
eXpl0it3r pushed a commit that referenced this issue Feb 18, 2023
@Bqleine
Add function for default RenderState (#178)
ac4f02c
mgrojo added a commit to mgrojo/ASFML that referenced this issue Jul 8, 2023
@mgrojo
sfRenderStates "constructors" from shaders and textures (issue #20)
c84ec88 
The set of constructors in the C++ API is conflated into a create function
with all possible default values in the parameters. Documentation inspired
by the C++ version.

Also, a default function is declared reusing those defaults in order to
match the following change made in CSFML:
SFML/CSFML#178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add function for default RenderState (#178) Bqleine/CSFML
2 participants
@eXpl0it3r @Bqleine