Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only lowercase keypresses are handled on Linux #1012

Closed
dexter3k opened this issue Dec 2, 2015 · 2 comments
Closed

Only lowercase keypresses are handled on Linux #1012

dexter3k opened this issue Dec 2, 2015 · 2 comments
Assignees
@binary1248
Labels
bug m:sfml-window p:linux
Milestone
2.4

Comments

@dexter3k
Copy link

dexter3k commented Dec 2, 2015

In WindowImplX11.cpp function "keysymToSF(xcb_keysym_t symbol)" handles only lowercase KeySym's(XK_a, XK_b, e.t.c.).
This causes SFML to generate sf::Keyboard::Unknown keycodes in button events when CapsLock and/or L/RShift is pressed.
As of Xlib manual uppercase presses are generated too and they should be handled as XK_A, XK_B, e.t.c.

I'm running Linux 3.19.0-33-generic Ubuntu-14.04.1 i686
@binary1248 binary1248 self-assigned this Dec 24, 2015
@binary1248 binary1248 added this to the 2.4 milestone Dec 24, 2015
binary1248 added a commit that referenced this issue Dec 24, 2015
@binary1248
Fixed modifiers causing sf::Keyboard::Unknown being returned in key e…
f037c27 
…vents on Unix (#1012). On Unix, SFML now tries harder to create proper key events on keyboards that shift keys which are typically unshifted on QWERTY layouts (this makes the numeric codes usable even on AZERTY layouts).
@binary1248 binary1248 mentioned this issue Dec 24, 2015
Merged
@binary1248
Copy link
Member

@SMemsky can you try out the patch I submitted in #1022?

@dexter3k
Copy link
Author

dexter3k commented Jan 2, 2016

Yes, patch seems to fix this problem on Ubuntu 14.04 with qwerty layout.

@binary1248 binary1248 mentioned this issue May 8, 2016
Open
eXpl0it3r pushed a commit that referenced this issue May 10, 2016
@binary1248 @eXpl0it3r
Fixed modifiers causing sf::Keyboard::Unknown being returned in key e…
556371e 
…vents on Unix (#1012). On Unix, SFML now tries harder to create proper key events on keyboards that shift keys which are typically unshifted on QWERTY layouts (this makes the numeric codes usable even on AZERTY layouts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binary1248 binary1248

Labels
bug m:sfml-window p:linux
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
3 participants
@eXpl0it3r @binary1248 @dexter3k