Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Modernize toolchain file #1411

Closed
wants to merge 1 commit into from
Closed

[iOS] Modernize toolchain file #1411

wants to merge 1 commit into from

Conversation

Ceylo
Copy link
Contributor

@Ceylo Ceylo commented Apr 8, 2018

  • Unused BUILD_ARM64 variable is removed
  • Support for Xcode < 4.3 (!!) is removed
  • Renamed all variables prefixed with CMAKE_
  • Made the toolchain file much less verbose (you still get the SDK being used and you can check other values from CMake cache displayed in CMake GUI)

If CI build is ok this should be ok. There is no expected side effect on SFML behavior itself.

@Ceylo
Modernize iOS toolchain: remove BUILD_ARM64, drop support for Xcode <…
ab57ff8 
…4.3 and don't pretend defining official CMake variables
@mantognini mantognini added this to the 2.6 milestone Apr 9, 2018
@JonnyPtn
Copy link
Contributor

JonnyPtn commented Apr 9, 2018

Looks good to me

@Ceylo Ceylo mentioned this pull request Apr 12, 2018
Closed
@Ceylo Ceylo changed the title Modernize iOS toolchain file [iOS] Modernize toolchain file Apr 12, 2018
@eXpl0it3r eXpl0it3r modified the milestones: 2.6, 2.5 Apr 14, 2018
@eXpl0it3r eXpl0it3r modified the milestones: 2.5, 2.6 May 9, 2018
@eXpl0it3r eXpl0it3r modified the milestones: 2.6, 2.5.1 May 17, 2018
@eXpl0it3r
Copy link
Member

Despite this being tagged as feature, do you think we could add this to SFML 2.5.1?

@JonnyPtn
Copy link
Contributor

I think that would be fine

@eXpl0it3r
Copy link
Member

Merged in ff011dc

@eXpl0it3r eXpl0it3r closed this Jun 4, 2018
@eXpl0it3r eXpl0it3r mentioned this pull request Nov 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binary1248 binary1248 binary1248 approved these changes

Assignees
No one assigned
Labels
feature m:config p:ios
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Ceylo @JonnyPtn @eXpl0it3r @binary1248 @mantognini