Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS resize bug #2618

Merged
merged 1 commit into from Jul 30, 2023
Merged

Fix macOS resize bug #2618

merged 1 commit into from Jul 30, 2023

Conversation

dogunbound
Copy link
Contributor

#2611

kimci86 stated that this may have better behavior than the previous pull request. I'm going to leave this up and see how we feel about it.

@dogunbound
Fix macOS resize bug
de320bf 
There is a commit up for the macOS resize bug where we get rid of a
previous fix entiry and just resize, but kimci86 stated that he found
better behavior with this solution. I'm going to put up this for code
review and we can compare it to SFML#2538
and see which we like best
@dogunbound dogunbound mentioned this pull request Jul 15, 2023
Closed
@eXpl0it3r eXpl0it3r added this to the 2.6.1 milestone Jul 17, 2023
@shane-tran-whitmire
Copy link

@kimci86 This is what you recommend, right?

@kimci86
Copy link
Contributor

kimci86 commented Jul 29, 2023

@kimci86 This is what you recommend, right?

Yes this works best for me.

@kimci86 kimci86 mentioned this pull request Jul 29, 2023
Merged
@ChrisThrasher
Copy link
Member

@kimci86 was telling me that instead of simply cherry picking #2631 we need to use this PR since some other changes in sf::WindowBase require that this PR be a bit different?

ChrisThrasher
ChrisThrasher approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@ChrisThrasher ChrisThrasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this PR makes resizing seem to work just fine on macOS

@ChrisThrasher ChrisThrasher merged commit 86285c5 into SFML:2.6.x Jul 30, 2023
37 checks passed
@dogunbound dogunbound deleted the cocoa_resize_bug_alternative branch April 7, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimci86 kimci86 kimci86 approved these changes

@ChrisThrasher ChrisThrasher ChrisThrasher approved these changes

Assignees
No one assigned
Labels
bug m:sfml-window p:macos
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dogunbound @shane-tran-whitmire @kimci86 @ChrisThrasher @eXpl0it3r