Fix missing include of <algorithm> #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure enough I can recreate these errors but only when I compile SFML in C++23 mode. Do you know what it is about the change of standard that causes this to manifest? |
ChrisThrasher
force-pushed
the
fix-macos-cpp23-build
branch
from
4a403c7
to
159a065
Compare
ChrisThrasher
approved these changes
May 24, 2024
|
Much appreciated 👍🏻 |
No idea. It must be the internal changes in Apple Clang's dependencies of standard library headers, but why it's needed is outside of my knowledge. |
Pull Request Test Coverage Report for Build 9218728463Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found that some macOS specific sources are missing dependency includes to
<algorithm>.This makes it unable to build SFML on C++23 using Apple Clang 15, shown on GitHub actions run below.
Run 1
Run 2
This commit adds the missing includes to
<algorithm>to fix this.Run 3 (fixed)
Tasks
How to test this PR?
Try to build SFML on macOS with Apple Clang 15 with C++23