OS X impl update #601
Merged
OS X impl update #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Apparently, there were some leaks not reported as such * Support for 32 bits computer is restored * Fix memory leak in sfStringToNSString (related to #484) * Unapply context when closing the window, freeing memory The following commits are related to ARC modifications: * 42f6e83 * 6edc4b9 * f6c9445 * 324d4a1 * 0d47056 Commit ac28902 is the last one before the introduction of ARC.
* Setting CMAKE_OSX_DEPLOYMENT_TARGET to something implies setting CMAKE_OSX_SYSROOT too * The default values are enough for most users * If someone is trying to compile SFML with 10.6 SDK it will simply fail later anyway
Templates are compatible with versions 4 and 5 of Xcode.
* Instead of configuring Xcode templates directly to /Library the files are first saved in CMAKE_CURRENT_BINARY_DIR * This avoid running CMake as root on some systems
These changes will ease the implementation of mouse grab (#394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some modification for OS X ready for review.
Basically, I reverted to non-ARC since it didn't work as I expected. The memory usage was climbing when recreating windows without being detected as leaks by Apple's tools. That's the biggest change here. See commit message for more details.
Other minor changes are explained in commit log as well.