New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X impl update #601

merged 10 commits into from May 23, 2014


None yet
3 participants

mantognini commented May 17, 2014

Here are some modification for OS X ready for review.

Basically, I reverted to non-ARC since it didn't work as I expected. The memory usage was climbing when recreating windows without being detected as leaks by Apple's tools. That's the biggest change here. See commit message for more details.

Other minor changes are explained in commit log as well.

mantognini added some commits May 17, 2014

Reverted OS X implementation to non-ARC
 * Apparently, there were some leaks not reported as such
 * Support for 32 bits computer is restored
 * Fix memory leak in sfStringToNSString (related to #484)
 * Unapply context when closing the window, freeing memory

The following commits are related to ARC modifications:

 * 42f6e83
 * 6edc4b9
 * f6c9445
 * 324d4a1
 * 0d47056

Commit ac28902 is the last one before the introduction of ARC.
Removed unnecessary check in cmake regarding the deployment target
 * Setting CMAKE_OSX_DEPLOYMENT_TARGET to something implies setting CMAKE_OSX_SYSROOT too
 * The default values are enough for most users
 * If someone is trying to compile SFML with 10.6 SDK it will simply fail later anyway
Templates are compatible with versions 4 and 5 of Xcode.
Improved CMake script
 * Instead of configuring Xcode templates directly to /Library the files are first saved in CMAKE_CURRENT_BINARY_DIR
 * This avoid running CMake as root on some systems
Moved more responsibilities to SFOpenGLView
These changes will ease the implementation of mouse grab (#394)

@mantognini mantognini merged commit 2215f55 into master May 23, 2014

@mantognini mantognini deleted the feature/osx branch May 23, 2014

@eXpl0it3r eXpl0it3r added the resolved label May 26, 2014

@mantognini mantognini removed their assignment Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment