Added CMake variables to select the modules to be built #800

MarioLiebisch · 2015-02-21T13:49:37Z

This addresses issue #798.

The only leftover issue I see is the fact that on most platforms we're always installing most third party dependencies, even if the modules aren't built.

LaurentGomila · 2015-02-21T14:24:18Z

CMakeLists.txt

@@ -44,11 +44,25 @@ else()
    set(SFML_BUILD_EXAMPLES FALSE)
 endif()

+# add options to select which modules to build
+sfml_set_option(SFML_BUILD_SYSTEM TRUE BOOL "TRUE to build SFML's System module. This setting is ignored, if any of the other modules is built.")


What's the point of not building sfml-system? I think we can remove this option.

Maybe building documentation only? Wasn't sure either.

We already can build only the doc with make doc. ;-)

It would still want dependencies and you couldn't install the docs only. But if you think we don't need that option, can cut it as well (same with the main one).

Indeed, I forget the issue at hand, sorry.

But wouldn't someone who's building the doc want to build at least one module of SFML?

Yeah, it's quite an edge case.

LaurentGomila · 2015-02-21T14:38:59Z

What's the problem with external libs? Your PR seems to handle them correctly.

MarioLiebisch · 2015-02-21T15:00:24Z

No problem in general, but let's assume you want to install system and network only (server), you'd still install all extlibs (i.e. on Windows). Guess I'll just update that part of the CMake script.

eXpl0it3r · 2015-02-21T16:09:54Z

you'd still install all extlibs (i.e. on Windows)

Did you test this? Afaik the extlibs have to be explicitly added to get installed so when you just pick one module it won't added the other ones, but maybe my memory serves me wrong.

MarioLiebisch · 2015-02-21T16:25:53Z

Right now you install the whole directory since the file names are toolchain dependent.

MarioLiebisch · 2015-02-25T14:14:58Z

So, any further comments regarding this? Especially related to whether to include SFML_BUILD_SYSTEM or ommit it.

mantognini · 2015-02-25T15:01:03Z

I also believe we don't need SFML_BUILD_SYSTEM. Beside that, this PR's changes will conflict with change with no_libsndfile but that's not a big deal.

binary1248 · 2015-03-14T18:34:36Z

This PR needs rebasing now that no_libsndfile is merged.

MarioLiebisch · 2015-03-23T19:45:59Z

Completely forgot about this; the branch is rebased and up to date again. Still not 100% sold regarding SFML_BUILD_SYSTEM though.

Bromeon · 2015-03-23T20:14:12Z

I would remove the option SFML_BUILD_SYSTEM, too. It's not really useful -- you just add confusion and possible error sources with more options. For example, you would then need to do all kinds of checks like "you can't use sfml-audio without sfml-system".

MarioLiebisch · 2015-03-23T20:59:58Z

For example, you would then need to do all kinds of checks like "you can't use sfml-audio without sfml-system".

To prevent this, dependencies are always built, so even with SFML_BUILD_SYSTEM set to false it's always built in case you try to build any of the other libraries.

But yeah, guess I'll just drop it then, unless there's some other opinion till tomorrow.

Bromeon · 2015-03-23T21:03:59Z

To prevent this, dependencies are always built, so even with SFML_BUILD_SYSTEM set to false it's always built in case you try to build any of the other libraries.

I personally don't like this way of hiding user errors. If the user ticks sfml-graphics but not sfml-system, he probably has a misconception of how the dependencies work -- and I'd rather tell him than just assume he didn't mean it.

Same with sfml-graphics and sfml-window at the moment, I would probably add an error message...

MarioLiebisch · 2015-03-23T21:53:50Z

True, there should be a warning, if it's possible to exclude dependencies, which are still built.

mantognini · 2015-07-05T10:20:40Z

So what's the status of this?

In any case, those lines need to be updated.

MarioLiebisch · 2015-07-05T10:46:08Z

Can have a look later this week; caught a cold. :(

mantognini · 2015-07-28T16:19:16Z

Before I forget: the framework part for OS X also need some update. See https://github.com/SFML/SFML/pull/933/files#diff-af3b638bc2a3e6c650974192a53c7291R272 (not tested)

MarioLiebisch · 2015-08-01T15:07:45Z

So we have any current open PR or changes that would conflict this? I'd rebase it, but don't want to do the work twice. :)

Bromeon · 2016-01-01T14:38:05Z

Are we going to include this in SFML 2.4? If so, it would be nice to perform the adaptations mentioned above.

eXpl0it3r · 2016-11-05T09:56:11Z

@MarioLiebisch Can you rebase this and include the possible changes that @mantognini mentioned?

MarioLiebisch · 2016-11-05T12:33:51Z

Done.

mantognini

This patch chunk should be applied as well.

Also, we could add an "assert" to make sure SFML_BUILD_WINDOW is on when SFML_BUILD_GRAPHICS is true.

mantognini · 2016-11-05T14:06:34Z

CMakeLists.txt

@@ -329,31 +339,33 @@ if(SFML_OS_WINDOWS)
 elseif(SFML_OS_MACOSX)

    # install extlibs dependencies only when used
-    if("${FLAC_LIBRARY}" STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/FLAC.framework")
+    if(SFML_BUILD_AUDIO AND FLAC_LIBRARY STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/FLAC.framework")


Audio dependencies should be moved together in a single if(SFML_BUILD_AUDIO) block. This includes Flac,

mantognini · 2016-11-05T14:06:47Z

CMakeLists.txt

    endif()

-    if("${OGG_LIBRARY}" STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/ogg.framework")
+    if(OGG_LIBRARY STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/ogg.framework")


mantognini · 2016-11-05T14:06:55Z

CMakeLists.txt

        install(DIRECTORY extlibs/libs-osx/Frameworks/ogg.framework DESTINATION ${CMAKE_INSTALL_FRAMEWORK_PREFIX})
    endif()

-    if("${VORBIS_LIBRARY}" STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/vorbis.framework")
+    if(VORBIS_LIBRARY STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/vorbis.framework")


Updated, although I think these should ultimatively moved to the modules' CMakeLists.txt rather than doing it globally here.

mantognini · 2016-11-05T14:07:18Z

CMakeLists.txt

        install(DIRECTORY extlibs/libs-osx/Frameworks/vorbis.framework DESTINATION ${CMAKE_INSTALL_FRAMEWORK_PREFIX})
    endif()

-    if("${VORBISENC_LIBRARY}" STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/vorbisenc.framework")
+    if(VORBISENC_LIBRARY STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/vorbisenc.framework")


mantognini · 2016-11-05T14:07:26Z

CMakeLists.txt

        install(DIRECTORY extlibs/libs-osx/Frameworks/vorbisenc.framework DESTINATION ${CMAKE_INSTALL_FRAMEWORK_PREFIX})
    endif()

-    if("${VORBISFILE_LIBRARY}" STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/vorbisfile.framework")
+    if(VORBISFILE_LIBRARY STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/vorbisfile.framework")


vorbisfile,

mantognini · 2016-11-05T14:07:37Z

CMakeLists.txt

        install(DIRECTORY extlibs/libs-osx/Frameworks/vorbisfile.framework DESTINATION ${CMAKE_INSTALL_FRAMEWORK_PREFIX})
    endif()

-    if("${OPENAL_LIBRARY}" STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/OpenAL.framework")
+    if(OPENAL_LIBRARY STREQUAL "${SFML_SOURCE_DIR}/extlibs/libs-osx/Frameworks/OpenAL.framework")


and OpenAL.

mantognini · 2016-11-05T14:16:49Z

Thanks for the rebase BTW. 👍

eXpl0it3r · 2017-02-28T00:02:41Z

Looks like this PR was a bit forgotten. Can you give this a rebase?

eXpl0it3r · 2017-03-23T00:25:07Z

Nearly feel bad for asking again, can you give this one last rebase? 😄

This addresses issue #798.

LaurentGomila reviewed Feb 21, 2015
View reviewed changes

mantognini added feature m:config labels Feb 21, 2015

mantognini assigned MarioLiebisch Feb 21, 2015

mantognini mentioned this pull request Feb 21, 2015

Give the possibility to configure/compile specified modules with cmake #798

Closed

eXpl0it3r mentioned this pull request Mar 23, 2015

Only link sfml-main for the GUI examples in release mode. #766

Merged

MarioLiebisch force-pushed the feature/selective_building branch from f58df27 to 4c19d1d Compare March 23, 2015 19:45

Bromeon mentioned this pull request Mar 26, 2015

Add CMake options to install examples and documentation separately. #844

Closed

binary1248 added this to the 2.4 milestone Apr 4, 2015

MarioLiebisch removed their assignment Apr 30, 2015

LaurentGomila mentioned this pull request Jul 28, 2015

Added four new CMake options #933

Closed

binary1248 modified the milestones: 2.5, 2.4 May 8, 2016

LaurentGomila mentioned this pull request Jun 7, 2016

Added Cmake flag to enable/disable building the networking library. #1096

Closed

eXpl0it3r added the s:undecided label Oct 6, 2016

MarioLiebisch force-pushed the feature/selective_building branch 2 times, most recently from fa0678b to 40cb8cd Compare November 5, 2016 12:33

mantognini requested changes Nov 5, 2016

View reviewed changes

MarioLiebisch force-pushed the feature/selective_building branch 2 times, most recently from 4d2c9ef to e83a01d Compare November 8, 2016 09:31

mantognini approved these changes Nov 8, 2016

View reviewed changes

eXpl0it3r added s:accepted and removed s:undecided labels Feb 28, 2017

eXpl0it3r assigned MarioLiebisch Feb 28, 2017

eXpl0it3r moved this from WIP to Review & Testing in SFML 2.5.0 Feb 28, 2017

MarioLiebisch force-pushed the feature/selective_building branch 2 times, most recently from 3a9ee64 to 1938ffc Compare February 28, 2017 08:20

eXpl0it3r moved this from Review & Testing to Ready in SFML 2.5.0 Mar 13, 2017

Added CMake variables to select the modules to be built

0b2ac85

This addresses issue #798.

eXpl0it3r force-pushed the feature/selective_building branch from 1938ffc to 0b2ac85 Compare April 4, 2017 12:56

eXpl0it3r merged commit 0b2ac85 into master Apr 25, 2017

eXpl0it3r deleted the feature/selective_building branch April 25, 2017 12:48

eXpl0it3r moved this from Ready to Merged in SFML 2.5.0 Apr 25, 2017

eXpl0it3r mentioned this pull request Apr 25, 2017

Improve cmake script for macOS #1215

Merged

jcowgill mentioned this pull request May 16, 2018

Multiple problems with pkg-config file installation #1433

Closed

Added CMake variables to select the modules to be built #800

Added CMake variables to select the modules to be built #800

Conversation

MarioLiebisch commented Feb 21, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LaurentGomila commented Feb 21, 2015

MarioLiebisch commented Feb 21, 2015

eXpl0it3r commented Feb 21, 2015

MarioLiebisch commented Feb 21, 2015

MarioLiebisch commented Feb 25, 2015

mantognini commented Feb 25, 2015

binary1248 commented Mar 14, 2015

MarioLiebisch commented Mar 23, 2015

Bromeon commented Mar 23, 2015

MarioLiebisch commented Mar 23, 2015

Bromeon commented Mar 23, 2015

MarioLiebisch commented Mar 23, 2015

mantognini commented Jul 5, 2015

MarioLiebisch commented Jul 5, 2015

mantognini commented Jul 28, 2015

MarioLiebisch commented Aug 1, 2015

Bromeon commented Jan 1, 2016

eXpl0it3r commented Nov 5, 2016

MarioLiebisch commented Nov 5, 2016

mantognini left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mantognini commented Nov 5, 2016

eXpl0it3r commented Feb 28, 2017

eXpl0it3r commented Mar 23, 2017